We were checking if dockerhub is a valid key in the
zuul_site_mirror_info/mirror_info dictionaries but did so without
quoting dockerhub as a string. This meant ansible tried to look up
dockerhub as a variable producing this error:
The conditional check 'dockerhub is in zuul_site_mirror_info' failed.
The error was: error while evaluating conditional (dockerhub is in
zuul_site_mirror_info): 'dockerhub' is undefined. 'dockerhub' is undefined
Fix this by quoting dockerhub so that we lookup the string as a key
instead of a variable.
Change-Id: Ie869b9b52fd0a5b70fc07548ce449937ed2c9589
This adds new style mirror_info handling to use-docker-mirror to give us
greater control over whether or not docker hub should be mirrored. We
ignore old style configuration if new style is present which gives us
this control. Otherwise we fallback to the old behavior.
We also update the ensure-docker test jobs to be triggered by updates to
the use-docker-mirror roles as ensure-docker includes this role. We
should get decent functional testing coverage this way.
Change-Id: Ia1b216a6dd68bcafbe599777037c5d7b1b3e8201
So that the docker mirror configuration can be used without the
install-docker role (e.g., if another process is used to install
docker on a target host), split the part of the role which
configures mirrors into its own role and include it in the
install-docker role.
Change-Id: I7cd7f61e2d1281cd2949c1f69a081c7217d0d328