Update patch set 2
Patch Set 2: (5 comments) Hi Jimmy, Thank you for the review! I fixed most of your comments, I added one follow-up comment and one question in line. Please check and let me know what you think. Thanks, Ildikó Patch-set: 2
This commit is contained in:
parent
fb1d38acaf
commit
0ea691ffb6
|
@ -23,6 +23,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9b906214_175c58b6",
|
||||
"filename": "doc/source/activities_and_processes.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 31,
|
||||
"author": {
|
||||
"id": 9562
|
||||
},
|
||||
"writtenOn": "2021-02-24T12:57:25Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "7bf8b65f_1f6d8fba",
|
||||
"range": {
|
||||
"startLine": 31,
|
||||
"startChar": 27,
|
||||
"endLine": 31,
|
||||
"endChar": 63
|
||||
},
|
||||
"revId": "5bf7325e56f4dd45b1deaa50bb7c3f3881b84e4c",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "0f7d9fa2_2809baea",
|
||||
|
@ -40,6 +64,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "21d3dad1_002cd6b7",
|
||||
"filename": "doc/source/activities_and_processes.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 38,
|
||||
"author": {
|
||||
"id": 9562
|
||||
},
|
||||
"writtenOn": "2021-02-24T12:57:25Z",
|
||||
"side": 1,
|
||||
"message": "I removed the \"three forces\" term from the earlier chapter where it was mentioned as it wasn\u0027t really defined there either. I don\u0027t think that we use it enough that would require to introduce a new term that readers need to remember and digest as it can be distracting.\n\nI also switched out \u0027developers\u0027 to \u0027contributors\u0027 to be more inclusive. In previous chapters I even highlighted both technical and non-technical contributors, which I should probably do here too. And there might be more angles that we want to add as the book forming that we can do easily this way.",
|
||||
"parentUuid": "0f7d9fa2_2809baea",
|
||||
"revId": "5bf7325e56f4dd45b1deaa50bb7c3f3881b84e4c",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "33bb9540_4ab1e7f0",
|
||||
|
@ -57,6 +99,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "32f233e3_baf633f9",
|
||||
"filename": "doc/source/activities_and_processes.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 48,
|
||||
"author": {
|
||||
"id": 9562
|
||||
},
|
||||
"writtenOn": "2021-02-24T12:57:25Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "33bb9540_4ab1e7f0",
|
||||
"revId": "5bf7325e56f4dd45b1deaa50bb7c3f3881b84e4c",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5514c57e_66eca8a7",
|
||||
|
@ -74,6 +134,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "07c15bb1_b304674f",
|
||||
"filename": "doc/source/activities_and_processes.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 53,
|
||||
"author": {
|
||||
"id": 9562
|
||||
},
|
||||
"writtenOn": "2021-02-24T12:57:25Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "5514c57e_66eca8a7",
|
||||
"revId": "5bf7325e56f4dd45b1deaa50bb7c3f3881b84e4c",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "859f9e82_f524466c",
|
||||
|
@ -90,6 +168,24 @@
|
|||
"revId": "5bf7325e56f4dd45b1deaa50bb7c3f3881b84e4c",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "127ff5f9_3820558d",
|
||||
"filename": "doc/source/activities_and_processes.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 89,
|
||||
"author": {
|
||||
"id": 9562
|
||||
},
|
||||
"writtenOn": "2021-02-24T12:57:25Z",
|
||||
"side": 1,
|
||||
"message": "I could add the link to the related Wikipedia article: https://en.wikipedia.org/wiki/Benevolent_dictator_for_life ?",
|
||||
"parentUuid": "859f9e82_f524466c",
|
||||
"revId": "5bf7325e56f4dd45b1deaa50bb7c3f3881b84e4c",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue