Well, sort of. We enable them but immediately filter out the ones we're
actually seeing, the rationale being that we can address these in a
piecemeal fashion without the risk of introducing new issues.
There's a lot more to be done here. However, the work done in oslo.db
[1] should provide a guide for how to resolve the outstanding issues.
[1] https://review.opendev.org/q/topic:"sqlalchemy-20"+project:openstack/oslo.db
Change-Id: I9e8d3e3a82c51c3c008ef7380f2f619ed492205e
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
The cinder requirements job is failing because our restriction
of importlib_metadata to py<3.8 is conflicting with change
I5febaed02e95 to global-requirements.
The cinder restriction to py<3.8 was originally made by
change I45d0851cdb5f (merged 21 Aug 2020).
Change-Id: I0293ae0e178c6b30edf38a0b31e60de4a4f6e21e
We split the '_check_sync' helper in 'cinder.db.manage' as part of
change Ic8c37145c66069e9194458fa7f622d98022fee4f. A comment was left in
this function which really belonged in the now-split function. Move it.
Change-Id: I9c1896c9eccd77363eedaa2817937cf8431f209a
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
With change[1], we introduced a redundant line in
cinder/scheduler/host_manager.py
This patch removes it.
[1] I07d74078dbb102490dd722029e32c74cec3aa44c
Change-Id: Ic4918c04493360a5913c8f4854bb44b6048af264
Add new config option `image_conversion_disable`, when it's set to
`True`, image disk_format and volume format must be the same format.
Otherwise will raise ImageUnacceptable exception.
`image_conversion_disable` config is bool option, default to `False`.
The idea behind this was that in certain high scale environments,
it is possible that a cloud allows both qcow2 and raw image uploads.
However, uploading a qcow2 image and creating a large number of
volumes can cause a tremendous amount of conversions that will kill
cinder-volume. It may be undesirable to have this, so a cloud
operator can opt to disallow conversions and enforce that the user
uploads the correct image type if they want to have volumes (aka
raw in rbd case).
Closes-Bug: #1970115
Change-Id: Ic481d68639d9460d1fd14225bc17a0d8287d5fd9
We shouldn't be using a mock CONF object in tests, instead we
should be using the 'flags' method of the cinder.tests.unit.test.
TestCase class.
See https://review.opendev.org/c/openstack/cinder/+/839793/6 if
you're not sure why.
Change-Id: I100b47697afa9241dad856baef613c687428d6d1
Some recent emails have made me realize that the basic contributor
doc doesn't have info about where you can find out who the current
PTL is. This patch moves the PTL info from the bottom of the doc
to a more visible place, and adds a brief description of what the
PTL does and who the electorate is.
Change-Id: Ib1fe4fba3d4911222b2c9393700c411d08fe2805