Some recent changes in python selenium bindings library made it do
certain things faster. That rendered our code for accessing Horizon
messages too restrictive, since it didn't wait a second. Previously,
when selenium queries took longer, the modal message had enough time
to appear, but now sometimes selenium is able to query the browser
during a narrow window when the spinner from a previous modal have
already disappeared, but the modal message still hasn't been
rendered. Adapt to these change by introducing a small (0.1 seconds)
margin to wait until message element appears.
Change-Id: I8f23ecaac9d007a1d3302eb9425d4064f438ca14
hz-field-directive was developed using hz images panel where every
single property had at least the no value filter applied. However,
when using it with properties that don't have the no value filter
applied and there is no value, we'll see the following in console.log
angular.js:12783 TypeError: Cannot read property 'then' of undefined
Change-Id: I14f8d56cc9086e7e25e11c081de34bc9d21389d0
Closes-Bug: #1614630
This addresses the suggestions found by Rob and Travis:
- The Admin panel doesn't show *all* images, just those either in the current
project or exposed as public (same as Project). (Travis)
FIX: The Admin panel now supplies is_public: None as the Python code does,
which allows all images to be shown.
- The 'Is Public' attribute is in the drawer now (even on large screen sizes)
and we can't sort by shared, public etc, as far as I can tell. I don't think
we specifically need the buttons like the previous design had, but it feels
like a regression to have no filtering or sorting on that field? Perhaps
someone with better glance knowledge could correct me.
FIX: Added 'visibility' as a synthesized field and added as a facet, making
sure to use the current project to correctly identify 'Shared with Project'.
Did *not* add 'Is Public' as that is a vestigial concept.
- Create/Edit Image > Image Details tab needs help text. Create has some info,
but Edit has nothing really. Also, we can drop that "description" header in
the help text; it doesnt add any value. This would be a nice improvement over
the Python version for novice users, and shouldnt take long to enter - just
pull info from the API docs.
NO CHANGE: Let's not block enablement on verbiage. I think we need a better
consistency and I don't believe the last-minute is the best time to add this
because it's very easy to create/find nits.
- Create Volume help text is also entirely blank. We should fill that out
with some useful instructions, IMO.
FIX: Added basic help text.
- Create Volume should default to the first Availability Zone if there is
only one, as it is a required field anyway.
FIX: I added logic for this, and also added in some test features so we don't
lose coverage.
- The Image Details page now longer lists the owner ID. I don't think this
is addressed by Travis' patch either.
FIX: This is now under the 'Security' heading.
- Kernel ID and Ramdisk ID seem empty in angular image details, but populated
in the python equivalent.
FIX: This was a regression that this patch fixes.
- Why are created/updated/ID separated into "Record Properties"? Is there
something in the API about this, or is it just a presentation construct?
CHANGE: Moved into the general 'Image' header. Added a filter so that these
can be implemented as basic property registrations.
- I think 'Filename' in angular image details can be hidden if empty.
CHANGE: Instead of hiding, we can show the standard '-' if no filename.
Change-Id: I4b770f9e61f9a8b1bd735d95c2ccc75bc21dd944
Partially-Implements: blueprint angularize-images-table
We no longer use tagging to trigger release, but rather
use the openstack release management project.
Change-Id: Idad9d8bd7297db2afff4ead4a029ebf001601371
Implements: blueprint xstatic-release-process
The ability to update (edit contents of) an object was
never present in the previous Swift UI. It was
explicitly blocked due to code in the swift_upload_object()
function, which has been removed in this patch. To
replace that "upload would replace existing contents"
check, this patch implements a client-side check to warn
the user if the upload would do so.
Partially-Implements: blueprint swift-ui-functionality
Change-Id: I9fb57dda59322907f0661372f9ee223551ff8a6e
This change is to support extra properties in project and user.
To show an extra property in project/user table, you can customize.
The explanation of the method to add an extra property is added
by this patch.
In addition, when you do a create or update user, you can specify a
value of extra property by setting in local_settings.py
Change-Id: Ifee491f2a55d9207fe5da70136f749e1fc4bab82
Implements: blueprint support-extra-prop-for-project-and-user
Orchestration Template Versions table and Template Functions tables
(which are actually template versions details) need filter function.
This patch adds filters and removes appeared checkboxes.
Change-Id: If3c5dfdb3f5915ee0b464c675d976f67ebb09be3
Closes-Bug: #1614889
Adds a word-break class that can be added to tables to prevent large
column values breaking the table shape.
Change-Id: Icca10d9c29254d176dc7f8b7c039bc19c3f52c72
Related-Bug: 1565724
Closes-Bug: 1584785
Now system administrators have CRUD abilities to manage floating IP.
1.floating IP list table
2.allocate floating IP to specific tenant
3.release/delete floating IP
Partially implements blueprint: manage-ips
Partially implements blueprint: syspanel-floating-ip-list
Change-Id: Ie5ec59740887d3845b933b37e6e875dbf08a4918
This patch reduces duplication arbitrary directory choices for
xstatic package locations in the static directory.
It moves the xstatic configuration from the library into the
settings file, and the supporting functions move to
the openstack_dashboard.utils.settings module. Having the xstatic
module list in settings allows deployers to add new modules.
It standardises the paths the files are served from, reducing
potential conflicts.
It simplifies the interaction with the xstatic modules, and also uses
the new MAIN variable if present to determine the entry points used.
Since some of the xstatic packages were installed into special
snowflakes directories (not following a pattern) the references to
those (bootstrap_scss and font_awesome) have been fixed.
Change-Id: Ia5be0e96fff1a4ddd6058d6b030ddf96da4b46e7
As per agreed in Austin summit and then confirmed in the midcycle,
the inline_edit form/functionality is more an issue than a solution.
It leads to many bugs and UX is not the best.
Implements: blueprint remove-table-inline-edit
Change-Id: I91394e4a63afadb66659b6b7c04cb7f8da948ff8
To pass a binary blob in a POST request, browser sets the header
'Content-Type: multipart/form-data', which in turn causes all form
fields' values to be passed as strings. Circumvent this by storing
original field values as a JSON string on client-side and decoding it
on server-side. As a result the setting HORIZON_IMAGES_UPLOAD_MODE =
'legacy' will start working together with Glance V2.
Closes-Bug: #1613703
Change-Id: I53a8fbba15e4c3c6c17d6ef1ffe701634efda149