Well, sort of. We enable them but immediately filter out the ones we're
actually seeing, the rationale being that we can address these in a
piecemeal fashion without the risk of introducing new issues.
There's a lot more to be done here. However, the work done in oslo.db
[1] should provide a guide for how to resolve the outstanding issues.
[1] https://review.opendev.org/q/topic:"sqlalchemy-20"+project:openstack/oslo.db
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Change-Id: If3a9bed39872012f8c64333cf378c434c22a2d15
When tox 'docs' target is called, first it installs the dependencies
(listed in 'deps') in 'installdeps' phase, then it installs manila
(with its requirements) in 'develop-inst' phase. In the latter case
'deps' is not used so that the constraints defined in 'deps' are not
used. This could lead to failures on stable branches when new packages
are released that break the build. To avoid this, the simplest solution
is to pre-install requirements, i.e. add requirements.txt to 'docs' tox
target.
Change-Id: I241ab2788b870060e1956a8fc029705378a2a8f4
Added command "tox -e newnote slug-goes-here" to create a new release note.
Fixes error that occurs when reno is not installed globally.
Also changed contributor documentation to include this new command.
Change-Id: I4568163d63e389891e701a424720567d065f70b3
The docs requirements migrated to doc/requirements.txt
we need not install things from requirements.txt.
Change-Id: Icba145059588222318ba866d6de8c4ce4df24def
The test code isn't part of the service.
Corresponding cinder change: I7b18453269cfc57bfbc9bd143d72948e88e60836
Change-Id: I71cc8b3154828f4aeea0afdf3fb59a79b8a8e707
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
Use the default value provided by tox:
https://tox.readthedocs.io/en/latest/config.html#conf-install_command
See discussion on the openstack-discuss ML [1]
for the complete context.
To get this fix in, we'll need to raise
a few requirements:
- eventlet because of the ssl issues with python3.6 in
older packages
(https://github.com/eventlet/eventlet/issues/371)
- oslo.messaging to fix the error "ACCESS_REFUSED - Login
was refused using authentication mechanism AMQPLAIN.".
- psycopg2-binary since 2.6.2 is blacklisted
- oslo.service was bumped to 2.1.0, to pick up its support
for eventlet>=0.22
- oslo.utils was bumped to match the lower constraint from
oslo.service at 2.1.0
[1] http://lists.openstack.org/pipermail/openstack-discuss/2020-April/014237.html
Change-Id: I6344f44fb955d631a4f0a13fa53ecc19826c7ea6
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
Fix:
W605 invalid escape sequence
This is the final change I plan for hacking, the remaining problems
need further investigation by manila team and decision whether and how
to solve them.
Change-Id: I73d73e044eaaf412bf7ace358a3f07c8d269d6cf
Fix:
E731 do not assign a lambda expression, use a def
I just marked the lambdas with noqa.
Fix also other problems found by hacking in files changed.
Change-Id: I4e47670f5a96e61fba617e4cb9478958f7089711
Fix:
E305 expected 2 blank lines after class or function definition, found 1
Fix also other problems found by hacking in these files.
Change-Id: I880afc40adf974cbb0e60f8dc5931f77d51f451b
Fix:
E241 multiple spaces after ':' (or ',')
Fix also a few other problems found by hacking in files changed.
Change-Id: I4c00551f29ad65df2631c8ae55fe2f022e872544
Fix:
F841 local variable 'e' is assigned to but never used
Also, fix other problems found by hacking in these files.
Change-Id: Ib6eaf27c8e6f1414acc9dbde41a35bd412b7161e
Fix F632 use ==/!= to compare str, bytes, and int literal
Fix also other problems in the files found by hacking checks.
Change-Id: I5122a9bbccd40d869b54fa3ddf754685aefb8d57
The repo is Python 3 now, so update hacking to version 3.0 which
supports Python 3.
Update local hacking checks for new flake8.
Many tests are failing, so disable all that fail and fix most of them in a
followup.
Change-Id: I34a767406ed9110fc6e0cf5015b88cf1e7f43801
* Remove doc/source/install/conf.py, it's not used
* Update openstackdocstheme version and remove settings that are now the
default.
* Use docs dependencies for api-ref building.
Change-Id: If37ed5bdbf6a1ef3107e66073eca9917704edee2
This commit adds a new tox target to build PDF documentation.
It's a community goal[0] to have PDF docs available.
Also some minor fixes are needed for PDF:
- Only show genindex and search for HTML. Theses elements do not make
sense within PDF documents
- Do not include full config sample files. This will not work and
produces a "Dimension too large" error during the latex run.
[0]
https://governance.openstack.org/tc/goals/selected/train/pdf-doc-generation.html
Change-Id: I66b8c47d599c97e66c2ca76faa66204d5e7c9c3b
The api documentation is now published on docs.openstack.org instead
of developer.openstack.org. Update all links that are changed to the
new location.
Note that the location API location /shared-file-system and not
/shared-file-systems.
Note that redirects will be set up as well but let's point now to the
new location.
For details, see:
http://lists.openstack.org/pipermail/openstack-discuss/2019-July/007828.html
Change-Id: I86f50af83be699fa7e0fb064abb20324e2d87b86
Was probably introduced by accident in [1]. Don't
need it anymore.
[1] I890ba4c54b0da10060767620ff5ff7e480d79a9c
Change-Id: Ib6fdb8c1488dde2308d8cc8bb3e79e1280d3e812
Older releases of pylint use an internal API of
the astroid library that causes pylint
exceptions when parsing modules. The errors
are like:
internal error with sending report for module ['manila/network/neutron/neutron_network_plugin.py']
'Import' object has no attribute 'infer_name_module'
So let's use the latest version available
that doesn't have this issue.
[1] https://github.com/PyCQA/astroid/issues/649
Change-Id: I6031111e5c72470313642307b4596806cd5408df
We use the mock library in our
unit tests which assigns mocked objects with
members at run time. This causes pylint to flag
"no-member" errors. We also test return values
on methods which return None explicitly, or
implicitly, this upsets pylint.
pylint is quite inflexible in the way it handles
ignores in code. We can add ignore statements all
over the test code, but that is quite infeasible.
So, this change lets us run pylint separately
for code and test modules. When running tests,
it adjusts the disabled pylint checks.
Change-Id: I85d3fe896ee95c52c3da55aedba8f4d72d0c299e
We don't use the tools/lintstack.py
script anymore since its removal in [1],
so cleanup the unused tox environment and
the gitignore corresponding files.
TrivialFix
[1] https://review.openstack.org/#/c/609791/
Change-Id: Id2d40c1f9f1ce71a22ba9836b90c3e917171a556
This issue was recently seen in cinder when the gate failed
to detect trailing whitespaces in '.inc' files.
As seen, manila was also prone to such issues but thankfully
no error was found in '.inc' after running against doc8.
It still seems important to include it in the testing to avoid
future similar issues.
Change-Id: Ie1fd4ddb4448c05559a31098302f84367fe6ed52
Set dependencies correctly for pylint job in tox.ini so
it does not report spurious E041 import errors on mock
and ddt modules. Also fix a reference to Cinder instead
of Manila in the pylint script.
Closes-Bug: #1813156
Change-Id: Ib160caae57e41a4d45483ff4faa599143e694abc
This commit does several things:
- Setup and run pylint directly rather than running through a script.
This allows the user to see what is happening while the user is running
through pylint.
- Allow the user to either run pylint on a particular changeset,
or the entire manila tree.
- Allow the user to run on a particular changeset. Using like HEAD~1,
etc.
- I disabled the tests that were reported by pylint.
The thought here would be go through the failures
and correct them.
- Update pylint to 2.1.1.
Change-Id: I398d1ba01a3fd7f1c86ad4065a7984d276f33383
Signed-off-by: Chuck Short <chucks@redhat.com>
Quotes around {posargs} cause the entire string to be combined into one
arg that gets passed to stestr. This prevents passing multiple args
(e.g. '--concurrency=16 some-regex')
Change-Id: I1088cfbab31befbd24e56add806d6e86fe46e5eb
base python version is 3, not 3.5 and
python 3.5 is not installed in some current
distros so running 'tox' locally fails.
Change-Id: Ie2449a433e07f4cafb55fe1db247ba9f854cef97
Updates the pylint and lint jobs to run under python3 by
changing the target python and updating the version of
pylint used.
Change-Id: Ie0ac158674fb22054b80864d33d9d7ecc82e3b36
Closes-bug: #1673824
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: I59ac21cb0d34f0b6767c736d0419eb6b874efca1
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
