2012-01-07 19:34:41 -08:00
|
|
|
[tox]
|
2021-05-18 22:22:53 +09:00
|
|
|
minversion = 3.18.0
|
2021-11-24 16:48:37 -06:00
|
|
|
envlist = py39,functional,pep8
|
2019-06-13 00:29:23 +01:00
|
|
|
# Automatic envs (pyXX) will only use the python version appropriate to that
|
|
|
|
# env and ignore basepython inherited from [testenv] if we set
|
|
|
|
# ignore_basepython_conflict.
|
2018-07-12 16:03:03 -05:00
|
|
|
ignore_basepython_conflict = True
|
2012-01-07 19:34:41 -08:00
|
|
|
|
|
|
|
[testenv]
|
2021-08-11 17:34:29 +00:00
|
|
|
basepython = python3
|
2013-08-15 14:36:40 -03:00
|
|
|
usedevelop = True
|
2021-05-18 22:22:53 +09:00
|
|
|
allowlist_externals =
|
2018-03-26 15:02:09 +01:00
|
|
|
bash
|
|
|
|
find
|
|
|
|
rm
|
|
|
|
env
|
2019-08-16 00:52:14 +09:00
|
|
|
make
|
2018-03-26 15:02:09 +01:00
|
|
|
setenv =
|
|
|
|
VIRTUAL_ENV={envdir}
|
|
|
|
LANGUAGE=en_US
|
|
|
|
LC_ALL=en_US.utf-8
|
|
|
|
OS_STDOUT_CAPTURE=1
|
|
|
|
OS_STDERR_CAPTURE=1
|
|
|
|
OS_TEST_TIMEOUT=160
|
2019-02-12 10:24:50 -06:00
|
|
|
PYTHONDONTWRITEBYTECODE=1
|
2021-08-16 12:35:27 +01:00
|
|
|
# TODO(stephenfin): Remove once we bump our upper-constraint to SQLAlchemy 2.0
|
|
|
|
SQLALCHEMY_WARN_20=1
|
2019-09-25 15:57:52 +01:00
|
|
|
deps =
|
2020-04-24 09:52:47 -05:00
|
|
|
-c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
|
2019-10-17 15:28:14 +02:00
|
|
|
-r{toxinidir}/requirements.txt
|
2019-09-25 15:57:52 +01:00
|
|
|
-r{toxinidir}/test-requirements.txt
|
2018-06-28 15:17:38 +01:00
|
|
|
passenv =
|
|
|
|
OS_DEBUG GENERATE_HASHES
|
2017-02-23 17:38:37 +01:00
|
|
|
# there is also secret magic in subunit-trace which lets you run in a fail only
|
2014-09-24 13:56:49 -04:00
|
|
|
# mode. To do this define the TRACE_FAILONLY environmental variable.
|
2016-10-17 13:53:10 -07:00
|
|
|
commands =
|
2021-07-12 15:34:26 +01:00
|
|
|
stestr run {posargs}
|
2018-03-26 15:02:09 +01:00
|
|
|
env TEST_OSPROFILER=1 stestr run --combine --no-discover 'nova.tests.unit.test_profiler'
|
2019-09-25 15:47:59 +01:00
|
|
|
stestr slowest
|
2018-12-10 11:22:54 +00:00
|
|
|
|
2017-06-02 16:45:41 +01:00
|
|
|
[testenv:mypy]
|
|
|
|
description =
|
|
|
|
Run type checks.
|
|
|
|
envdir = {toxworkdir}/shared
|
|
|
|
commands =
|
|
|
|
bash tools/mypywrap.sh {posargs}
|
|
|
|
|
2012-01-07 19:34:41 -08:00
|
|
|
[testenv:pep8]
|
2018-06-28 15:17:38 +01:00
|
|
|
description =
|
|
|
|
Run style checks.
|
2018-08-02 11:31:41 +01:00
|
|
|
envdir = {toxworkdir}/shared
|
2021-08-26 14:16:19 +01:00
|
|
|
deps =
|
|
|
|
{[testenv]deps}
|
|
|
|
autopep8
|
2013-05-17 12:54:12 -07:00
|
|
|
commands =
|
2021-06-11 11:47:06 +02:00
|
|
|
{[testenv:mypy]commands}
|
2021-08-26 14:16:19 +01:00
|
|
|
# check if autopep8 would alter the formatting but don't actually change it
|
|
|
|
# so we can gate on this in the ci
|
|
|
|
autopep8 --exit-code --max-line-length=79 --diff -r nova doc setup.py
|
|
|
|
# since autopep8 only tries to make minimal changes to conform to pep8 we still need to run
|
|
|
|
# our hacking and flake8 check to keep our existing code style consistent.
|
|
|
|
# The full list of issues addressable by autopep8 can be found here
|
|
|
|
# https://pypi.org/project/autopep8/#features
|
2015-07-24 16:05:49 +01:00
|
|
|
bash tools/flake8wrap.sh {posargs}
|
2017-03-15 15:57:23 +00:00
|
|
|
# Check that all JSON files don't have \r\n in line.
|
|
|
|
bash -c "! find doc/ -type f -name *.json | xargs grep -U -n $'\r'"
|
2016-07-13 13:39:47 +02:00
|
|
|
# Check that all included JSON files are valid JSON
|
|
|
|
bash -c '! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2>&1 > /dev/null | grep -B1 -v ^python'
|
2012-01-07 19:34:41 -08:00
|
|
|
|
2021-08-26 14:16:19 +01:00
|
|
|
[testenv:autopep8]
|
|
|
|
deps = autopep8
|
|
|
|
commands =
|
|
|
|
autopep8 --exit-code --max-line-length=79 --in-place -r nova doc setup.py
|
|
|
|
|
2017-03-15 13:00:10 -04:00
|
|
|
[testenv:fast8]
|
2018-06-28 15:17:38 +01:00
|
|
|
description =
|
|
|
|
Run style checks on the changes made since HEAD~. For a full run including docs, use 'pep8'
|
2018-08-02 11:31:41 +01:00
|
|
|
envdir = {toxworkdir}/shared
|
2017-03-15 13:00:10 -04:00
|
|
|
commands =
|
|
|
|
bash tools/flake8wrap.sh -HEAD
|
|
|
|
|
2021-06-16 12:00:19 +01:00
|
|
|
[testenv:validate-backport]
|
|
|
|
description =
|
|
|
|
Determine whether a backport is ready to be merged by checking whether it has
|
|
|
|
already been merged to master or more recent stable branches.
|
|
|
|
deps =
|
|
|
|
skipsdist = true
|
|
|
|
commands =
|
|
|
|
bash tools/check-cherry-picks.sh
|
|
|
|
|
2014-11-06 11:32:34 +01:00
|
|
|
[testenv:functional]
|
2019-10-14 12:14:35 +01:00
|
|
|
description =
|
|
|
|
Run functional tests using python3.
|
Use external placement in functional tests
Adjust the fixtures used by the functional tests so they
use placement database and web fixtures defined by placement
code. To avoid making redundant changes, the solely placement-
related unit and functional tests are removed, but the placement
code itself is not (yet).
openstack-placement is required by the functional tests. It is not
added to test-requirements as we do not want unit tests to depend
on placement in any way, and we enforce this by not having placement
in the test env.
The concept of tox-siblings is used to ensure that the
placement requirement will be satisfied correctly if there is a
depends-on. To make this happen, the functional jobs defined in
.zuul.yaml are updated to require openstack/placement.
tox.ini has to be updated to use a envdir that is the same
name as job. Otherwise the tox siblings role in ansible cannot work.
The handling of the placement fixtures is moved out of nova/test.py
into the functional tests that actually use it because we do not
want unit tests (which get the base test class out of test.py) to
have anything to do with placement. This requires adjusting some
test files to use absolute import.
Similarly, a test of the comparison function for the api samples tests
is moved into functional, because it depends on placement functionality,
TestUpgradeCheckResourceProviders in unit.cmd.test_status is moved into
a new test file: nova/tests/functional/test_nova_status.py. This is done
because it requires the PlacementFixture, which is only available to
functional tests. A MonkeyPatch is required in the test to make sure that
the right context managers are used at the right time in the command
itself (otherwise some tables do no exist). In the test itself, to avoid
speaking directly to the placement database, which would require
manipulating the RequestContext objects, resource providers are now
created over the API.
Co-Authored-By: Balazs Gibizer <balazs.gibizer@ericsson.com>
Change-Id: Idaed39629095f86d24a54334c699a26c218c6593
2018-11-14 14:02:25 +01:00
|
|
|
# As nova functional tests import the PlacementFixture from the placement
|
2020-04-10 18:28:35 -05:00
|
|
|
# repository these tests are, by default, set up to run with openstack-placement
|
|
|
|
# from pypi. In the gate, Zuul will use the installed version of placement (stable
|
|
|
|
# branch version on stable gate run) OR the version of placement the Depends-On in
|
|
|
|
# the commit message suggests. If you want to run the tests with latest master from
|
|
|
|
# the placement repo, modify the dep line to point at master, example:
|
|
|
|
# deps =
|
|
|
|
# {[testenv]deps}
|
|
|
|
# git+https://opendev.org/openstack/placement#egg=openstack-placement
|
|
|
|
# If you want to run the test locally with an un-merged placement change,
|
|
|
|
# modify the dep line to point to your dependency or pip install placement
|
|
|
|
# into the appropriate tox virtualenv.
|
|
|
|
# NOTE: We express the requirement here instead of test-requirements
|
|
|
|
# because we do not want placement present during unit tests.
|
Use external placement in functional tests
Adjust the fixtures used by the functional tests so they
use placement database and web fixtures defined by placement
code. To avoid making redundant changes, the solely placement-
related unit and functional tests are removed, but the placement
code itself is not (yet).
openstack-placement is required by the functional tests. It is not
added to test-requirements as we do not want unit tests to depend
on placement in any way, and we enforce this by not having placement
in the test env.
The concept of tox-siblings is used to ensure that the
placement requirement will be satisfied correctly if there is a
depends-on. To make this happen, the functional jobs defined in
.zuul.yaml are updated to require openstack/placement.
tox.ini has to be updated to use a envdir that is the same
name as job. Otherwise the tox siblings role in ansible cannot work.
The handling of the placement fixtures is moved out of nova/test.py
into the functional tests that actually use it because we do not
want unit tests (which get the base test class out of test.py) to
have anything to do with placement. This requires adjusting some
test files to use absolute import.
Similarly, a test of the comparison function for the api samples tests
is moved into functional, because it depends on placement functionality,
TestUpgradeCheckResourceProviders in unit.cmd.test_status is moved into
a new test file: nova/tests/functional/test_nova_status.py. This is done
because it requires the PlacementFixture, which is only available to
functional tests. A MonkeyPatch is required in the test to make sure that
the right context managers are used at the right time in the command
itself (otherwise some tables do no exist). In the test itself, to avoid
speaking directly to the placement database, which would require
manipulating the RequestContext objects, resource providers are now
created over the API.
Co-Authored-By: Balazs Gibizer <balazs.gibizer@ericsson.com>
Change-Id: Idaed39629095f86d24a54334c699a26c218c6593
2018-11-14 14:02:25 +01:00
|
|
|
deps =
|
2019-09-25 15:57:52 +01:00
|
|
|
{[testenv]deps}
|
2020-04-10 18:28:35 -05:00
|
|
|
openstack-placement>=1.0.0
|
2014-11-06 11:32:34 +01:00
|
|
|
commands =
|
2021-07-12 15:34:26 +01:00
|
|
|
stestr --test-path=./nova/tests/functional run {posargs}
|
2017-09-26 15:27:35 -04:00
|
|
|
stestr slowest
|
2014-11-06 11:32:34 +01:00
|
|
|
|
2018-08-08 11:03:25 +01:00
|
|
|
[testenv:functional-py36]
|
2019-10-14 12:14:35 +01:00
|
|
|
description =
|
|
|
|
Run functional tests using python3.6.
|
Use external placement in functional tests
Adjust the fixtures used by the functional tests so they
use placement database and web fixtures defined by placement
code. To avoid making redundant changes, the solely placement-
related unit and functional tests are removed, but the placement
code itself is not (yet).
openstack-placement is required by the functional tests. It is not
added to test-requirements as we do not want unit tests to depend
on placement in any way, and we enforce this by not having placement
in the test env.
The concept of tox-siblings is used to ensure that the
placement requirement will be satisfied correctly if there is a
depends-on. To make this happen, the functional jobs defined in
.zuul.yaml are updated to require openstack/placement.
tox.ini has to be updated to use a envdir that is the same
name as job. Otherwise the tox siblings role in ansible cannot work.
The handling of the placement fixtures is moved out of nova/test.py
into the functional tests that actually use it because we do not
want unit tests (which get the base test class out of test.py) to
have anything to do with placement. This requires adjusting some
test files to use absolute import.
Similarly, a test of the comparison function for the api samples tests
is moved into functional, because it depends on placement functionality,
TestUpgradeCheckResourceProviders in unit.cmd.test_status is moved into
a new test file: nova/tests/functional/test_nova_status.py. This is done
because it requires the PlacementFixture, which is only available to
functional tests. A MonkeyPatch is required in the test to make sure that
the right context managers are used at the right time in the command
itself (otherwise some tables do no exist). In the test itself, to avoid
speaking directly to the placement database, which would require
manipulating the RequestContext objects, resource providers are now
created over the API.
Co-Authored-By: Balazs Gibizer <balazs.gibizer@ericsson.com>
Change-Id: Idaed39629095f86d24a54334c699a26c218c6593
2018-11-14 14:02:25 +01:00
|
|
|
deps = {[testenv:functional]deps}
|
2018-08-08 11:03:25 +01:00
|
|
|
commands =
|
|
|
|
{[testenv:functional]commands}
|
|
|
|
|
2018-12-10 11:22:54 +00:00
|
|
|
[testenv:functional-py37]
|
2019-10-14 12:14:35 +01:00
|
|
|
description =
|
|
|
|
Run functional tests using python3.7.
|
2019-01-14 17:22:35 +00:00
|
|
|
deps = {[testenv:functional]deps}
|
2018-12-10 11:22:54 +00:00
|
|
|
commands =
|
|
|
|
{[testenv:functional]commands}
|
|
|
|
|
2020-05-04 14:11:40 -05:00
|
|
|
[testenv:functional-py38]
|
|
|
|
description =
|
|
|
|
Run functional tests using python3.8.
|
|
|
|
deps = {[testenv:functional]deps}
|
|
|
|
commands =
|
|
|
|
{[testenv:functional]commands}
|
|
|
|
|
2021-10-12 12:26:02 -05:00
|
|
|
[testenv:functional-without-sample-db-tests]
|
|
|
|
description =
|
|
|
|
Run functional tests by excluding the API|Notification
|
|
|
|
sample tests and DB tests. This env is used in
|
|
|
|
placement-nova-tox-functional-py38 job which is defined and
|
|
|
|
run in placement.
|
|
|
|
deps = {[testenv:functional]deps}
|
|
|
|
commands =
|
|
|
|
stestr --test-path=./nova/tests/functional run --exclude-regex '((?:api|notification)_sample_tests|functional\.db\.)' {posargs}
|
|
|
|
|
2020-11-02 11:54:36 +01:00
|
|
|
[testenv:functional-py39]
|
|
|
|
description =
|
|
|
|
Run functional tests using python3.9.
|
|
|
|
deps = {[testenv:functional]deps}
|
|
|
|
commands =
|
|
|
|
{[testenv:functional]commands}
|
|
|
|
|
2015-12-03 17:24:53 -05:00
|
|
|
[testenv:api-samples]
|
2020-09-29 17:32:56 +01:00
|
|
|
envdir = {toxworkdir}/functional
|
2018-03-26 15:02:09 +01:00
|
|
|
setenv =
|
|
|
|
{[testenv]setenv}
|
|
|
|
GENERATE_SAMPLES=True
|
|
|
|
PYTHONHASHSEED=0
|
2019-01-28 16:44:33 -05:00
|
|
|
deps = {[testenv:functional]deps}
|
2015-12-03 17:24:53 -05:00
|
|
|
commands =
|
2018-02-16 17:22:59 -05:00
|
|
|
stestr --test-path=./nova/tests/functional/api_sample_tests run {posargs}
|
2017-09-26 15:27:35 -04:00
|
|
|
stestr slowest
|
2015-12-03 17:24:53 -05:00
|
|
|
|
2014-03-19 10:56:49 -07:00
|
|
|
[testenv:genconfig]
|
2018-08-02 11:31:41 +01:00
|
|
|
envdir = {toxworkdir}/shared
|
2018-06-28 15:17:38 +01:00
|
|
|
commands =
|
|
|
|
oslo-config-generator --config-file=etc/nova/nova-config-generator.conf
|
2014-03-19 10:56:49 -07:00
|
|
|
|
2016-06-21 16:53:57 -04:00
|
|
|
[testenv:genpolicy]
|
2018-08-02 11:31:41 +01:00
|
|
|
envdir = {toxworkdir}/shared
|
2018-06-28 15:17:38 +01:00
|
|
|
commands =
|
|
|
|
oslopolicy-sample-generator --config-file=etc/nova/nova-policy-generator.conf
|
2016-06-21 16:53:57 -04:00
|
|
|
|
2012-05-25 15:27:03 -04:00
|
|
|
[testenv:cover]
|
2018-06-28 15:17:38 +01:00
|
|
|
# TODO(stephenfin): Remove the PYTHON hack below in favour of a [coverage]
|
|
|
|
# section once we rely on coverage 4.3+
|
|
|
|
#
|
|
|
|
# https://bitbucket.org/ned/coveragepy/issues/519/
|
2018-08-02 11:31:41 +01:00
|
|
|
envdir = {toxworkdir}/shared
|
2018-06-28 15:17:38 +01:00
|
|
|
setenv =
|
|
|
|
{[testenv]setenv}
|
|
|
|
PYTHON=coverage run --source nova --parallel-mode
|
2015-10-19 17:38:17 +11:00
|
|
|
commands =
|
|
|
|
coverage erase
|
2018-02-16 17:22:59 -05:00
|
|
|
stestr run {posargs}
|
2017-11-21 19:01:11 -05:00
|
|
|
coverage combine
|
|
|
|
coverage html -d cover
|
|
|
|
coverage xml -o cover/coverage.xml
|
2017-02-21 19:51:47 +08:00
|
|
|
coverage report
|
2015-10-19 17:38:17 +11:00
|
|
|
|
2016-10-11 21:55:05 +00:00
|
|
|
[testenv:debug]
|
2018-08-02 11:31:41 +01:00
|
|
|
envdir = {toxworkdir}/shared
|
2016-10-11 21:55:05 +00:00
|
|
|
commands =
|
|
|
|
oslo_debug_helper {posargs}
|
|
|
|
|
2012-01-07 19:34:41 -08:00
|
|
|
[testenv:venv]
|
2018-03-16 10:23:26 +00:00
|
|
|
deps =
|
2019-09-25 15:57:52 +01:00
|
|
|
{[testenv]deps}
|
2018-03-16 10:23:26 +00:00
|
|
|
-r{toxinidir}/doc/requirements.txt
|
2018-06-28 15:17:38 +01:00
|
|
|
commands =
|
|
|
|
{posargs}
|
2013-05-17 12:54:12 -07:00
|
|
|
|
2014-04-16 16:56:00 -07:00
|
|
|
[testenv:docs]
|
2018-06-28 15:17:38 +01:00
|
|
|
description =
|
2018-10-26 17:53:03 +01:00
|
|
|
Build main documentation.
|
2019-10-25 12:37:38 -04:00
|
|
|
# Note that we don't use {[testenv]deps} for deps here because we don't want
|
|
|
|
# to install (test-)requirements.txt for docs.
|
2019-09-25 15:57:52 +01:00
|
|
|
deps =
|
2020-04-24 09:52:47 -05:00
|
|
|
-c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
|
2019-09-25 15:57:52 +01:00
|
|
|
-r{toxinidir}/doc/requirements.txt
|
2015-01-21 22:25:10 -05:00
|
|
|
commands =
|
2019-08-16 00:52:14 +09:00
|
|
|
rm -rf doc/build/html doc/build/doctrees
|
2020-09-10 15:12:56 +01:00
|
|
|
sphinx-build -W --keep-going -b html -j auto doc/source doc/build/html
|
2018-03-16 10:23:26 +00:00
|
|
|
# Test the redirects. This must run after the main docs build
|
|
|
|
whereto doc/build/html/.htaccess doc/test/redirect-tests.txt
|
2015-10-01 17:27:50 -05:00
|
|
|
|
2019-08-16 00:52:14 +09:00
|
|
|
[testenv:pdf-docs]
|
|
|
|
description =
|
|
|
|
Build PDF documentation.
|
|
|
|
envdir = {toxworkdir}/docs
|
|
|
|
deps = {[testenv:docs]deps}
|
|
|
|
commands =
|
|
|
|
rm -rf doc/build/pdf
|
2020-09-10 15:12:56 +01:00
|
|
|
sphinx-build -W --keep-going -b latex -j auto doc/source doc/build/pdf
|
2019-08-16 00:52:14 +09:00
|
|
|
make -C doc/build/pdf
|
|
|
|
|
2015-10-01 17:27:50 -05:00
|
|
|
[testenv:api-guide]
|
2018-06-28 15:17:38 +01:00
|
|
|
description =
|
2019-07-22 18:08:40 +02:00
|
|
|
Generate the API guide. Called from CI scripts to test and publish to docs.openstack.org.
|
2018-06-28 15:16:26 +01:00
|
|
|
envdir = {toxworkdir}/docs
|
2018-06-28 15:17:38 +01:00
|
|
|
deps = {[testenv:docs]deps}
|
2015-10-01 17:27:50 -05:00
|
|
|
commands =
|
2018-06-28 15:17:38 +01:00
|
|
|
rm -rf api-guide/build
|
2020-09-10 15:12:56 +01:00
|
|
|
sphinx-build -W --keep-going -b html -j auto api-guide/source api-guide/build/html
|
2014-04-16 16:56:00 -07:00
|
|
|
|
2016-03-29 11:56:21 -04:00
|
|
|
[testenv:api-ref]
|
2018-06-28 15:17:38 +01:00
|
|
|
description =
|
2019-07-22 18:08:40 +02:00
|
|
|
Generate the API ref. Called from CI scripts to test and publish to docs.openstack.org.
|
2018-06-28 15:16:26 +01:00
|
|
|
envdir = {toxworkdir}/docs
|
2018-06-28 15:17:38 +01:00
|
|
|
deps = {[testenv:docs]deps}
|
2016-03-29 11:56:21 -04:00
|
|
|
commands =
|
2016-04-20 11:20:05 -04:00
|
|
|
rm -rf api-ref/build
|
2020-09-10 15:12:56 +01:00
|
|
|
sphinx-build -W --keep-going -b html -j auto api-ref/source api-ref/build/html
|
2016-03-29 11:56:21 -04:00
|
|
|
|
2015-11-05 12:12:28 +01:00
|
|
|
[testenv:releasenotes]
|
2018-06-28 15:17:38 +01:00
|
|
|
description =
|
|
|
|
Generate release notes.
|
2018-06-28 15:16:26 +01:00
|
|
|
envdir = {toxworkdir}/docs
|
2018-06-28 15:17:38 +01:00
|
|
|
deps = {[testenv:docs]deps}
|
2018-01-16 17:02:40 +00:00
|
|
|
commands =
|
|
|
|
rm -rf releasenotes/build
|
2020-09-10 15:12:56 +01:00
|
|
|
sphinx-build -W --keep-going -b html -j auto releasenotes/source releasenotes/build/html
|
2015-11-05 12:12:28 +01:00
|
|
|
|
2018-10-26 17:53:03 +01:00
|
|
|
[testenv:all-docs]
|
|
|
|
description =
|
|
|
|
Build all documentation including API guides and refs.
|
|
|
|
envdir = {toxworkdir}/docs
|
2019-09-25 15:57:52 +01:00
|
|
|
deps = {[testenv:docs]deps}
|
2018-10-26 17:53:03 +01:00
|
|
|
commands =
|
|
|
|
{[testenv:docs]commands}
|
|
|
|
{[testenv:api-guide]commands}
|
|
|
|
{[testenv:api-ref]commands}
|
|
|
|
{[testenv:releasenotes]commands}
|
|
|
|
|
2018-06-28 15:17:38 +01:00
|
|
|
[testenv:bandit]
|
|
|
|
# NOTE(browne): This is required for the integration test job of the bandit
|
|
|
|
# project. Please do not remove.
|
2018-08-02 11:31:41 +01:00
|
|
|
envdir = {toxworkdir}/shared
|
2018-06-28 15:17:38 +01:00
|
|
|
commands = bandit -r nova -x tests -n 5 -ll
|
|
|
|
|
2013-05-17 12:54:12 -07:00
|
|
|
[flake8]
|
2016-08-04 11:31:56 -04:00
|
|
|
# E125 is deliberately excluded. See
|
|
|
|
# https://github.com/jcrocholl/pep8/issues/126. It's just wrong.
|
|
|
|
#
|
|
|
|
# Most of the whitespace related rules (E12* and E131) are excluded
|
|
|
|
# because while they are often useful guidelines, strict adherence to
|
|
|
|
# them ends up causing some really odd code formatting and forced
|
|
|
|
# extra line breaks. Updating code to enforce these will be a hard sell.
|
|
|
|
#
|
|
|
|
# H405 is another one that is good as a guideline, but sometimes
|
|
|
|
# multiline doc strings just don't have a natural summary
|
|
|
|
# line. Rejecting code for this reason is wrong.
|
|
|
|
#
|
2014-06-09 14:45:26 -07:00
|
|
|
# E251 Skipped due to https://github.com/jcrocholl/pep8/issues/301
|
2019-04-10 10:02:03 +01:00
|
|
|
#
|
|
|
|
# W504 skipped since you must choose either W503 or W504 (they conflict)
|
|
|
|
#
|
2019-04-12 17:06:04 +01:00
|
|
|
# E731 temporarily skipped because of the number of
|
2019-04-10 10:02:03 +01:00
|
|
|
# these that have to be fixed
|
2017-02-08 16:41:31 +01:00
|
|
|
enable-extensions = H106,H203,H904
|
2020-01-20 16:18:19 +00:00
|
|
|
ignore = E121,E122,E123,E124,E125,E126,E127,E128,E129,E131,E251,H405,W504,E731,H238
|
2020-08-31 15:01:53 +01:00
|
|
|
exclude = .venv,.git,.tox,dist,*lib/python*,*egg,build,releasenotes
|
2014-10-29 12:22:29 -07:00
|
|
|
# To get a list of functions that are more complex than 25, set max-complexity
|
|
|
|
# to 25 and run 'tox -epep8'.
|
2019-04-10 10:02:03 +01:00
|
|
|
# 39 is currently the most complex thing we have
|
2014-10-16 21:04:08 -07:00
|
|
|
# TODO(jogo): get this number down to 25 or so
|
2019-04-10 10:02:03 +01:00
|
|
|
max-complexity=40
|
2013-05-17 12:54:12 -07:00
|
|
|
|
|
|
|
[hacking]
|
2019-12-16 10:20:03 +00:00
|
|
|
import_exceptions = typing,nova.i18n
|
|
|
|
|
|
|
|
[flake8:local-plugins]
|
|
|
|
extension =
|
|
|
|
N307 = checks:import_no_db_in_virt
|
|
|
|
N309 = checks:no_db_session_in_public_api
|
|
|
|
N310 = checks:use_timeutils_utcnow
|
|
|
|
N311 = checks:import_no_virt_driver_import_deps
|
|
|
|
N312 = checks:import_no_virt_driver_config_deps
|
|
|
|
N313 = checks:capital_cfg_help
|
|
|
|
N316 = checks:assert_true_instance
|
|
|
|
N317 = checks:assert_equal_type
|
|
|
|
N335 = checks:assert_raises_regexp
|
2020-05-18 17:09:25 +01:00
|
|
|
N319 = checks:no_translate_logs
|
2019-12-16 10:20:03 +00:00
|
|
|
N337 = checks:no_import_translation_in_tests
|
|
|
|
N320 = checks:no_setting_conf_directly_in_tests
|
|
|
|
N322 = checks:no_mutable_default_args
|
|
|
|
N323 = checks:check_explicit_underscore_import
|
|
|
|
N324 = checks:use_jsonutils
|
|
|
|
N332 = checks:check_api_version_decorator
|
|
|
|
N326 = checks:CheckForTransAdd
|
|
|
|
N334 = checks:assert_true_or_false_with_in
|
|
|
|
N336 = checks:dict_constructor_with_list_copy
|
|
|
|
N338 = checks:assert_equal_in
|
|
|
|
N339 = checks:check_http_not_implemented
|
|
|
|
N340 = checks:check_greenthread_spawns
|
|
|
|
N341 = checks:check_no_contextlib_nested
|
|
|
|
N342 = checks:check_config_option_in_central_place
|
|
|
|
N350 = checks:check_policy_registration_in_central_place
|
|
|
|
N351 = checks:check_policy_enforce
|
|
|
|
N343 = checks:check_doubled_words
|
|
|
|
N348 = checks:no_os_popen
|
|
|
|
N352 = checks:no_log_warn
|
|
|
|
N349 = checks:CheckForUncalledTestClosure
|
|
|
|
N353 = checks:check_context_log
|
|
|
|
N355 = checks:no_assert_equal_true_false
|
|
|
|
N356 = checks:no_assert_true_false_is_not
|
|
|
|
N357 = checks:check_uuid4
|
|
|
|
N358 = checks:return_followed_by_space
|
|
|
|
N359 = checks:no_redundant_import_alias
|
|
|
|
N360 = checks:yield_followed_by_space
|
|
|
|
N361 = checks:assert_regexpmatches
|
|
|
|
N362 = checks:privsep_imports_not_aliased
|
|
|
|
N363 = checks:did_you_mean_tuple
|
|
|
|
N364 = checks:nonexistent_assertion_methods_and_attributes
|
|
|
|
N365 = checks:useless_assertion
|
2020-09-28 22:35:00 +09:00
|
|
|
N366 = checks:check_assert_has_calls
|
2021-08-23 19:23:31 +02:00
|
|
|
N367 = checks:do_not_alias_mock_class
|
|
|
|
N368 = checks:do_not_use_mock_class_as_new_mock_value
|
2022-01-12 04:09:29 +00:00
|
|
|
N369 = checks:check_lockutils_rwlocks
|
2019-12-16 10:20:03 +00:00
|
|
|
paths =
|
|
|
|
./nova/hacking
|
2014-08-14 15:06:00 +10:00
|
|
|
|
2015-07-10 18:38:51 +00:00
|
|
|
[testenv:bindep]
|
|
|
|
# Do not install any requirements. We want this to be fast and work even if
|
|
|
|
# system dependencies are missing, since it's used to tell you what system
|
|
|
|
# dependencies are missing! This also means that bindep must be installed
|
|
|
|
# separately, outside of the requirements files, and develop mode disabled
|
2019-09-25 15:57:52 +01:00
|
|
|
# explicitly to avoid unnecessarily installing the checked-out repo too
|
2015-07-10 18:38:51 +00:00
|
|
|
usedevelop = False
|
2018-06-28 15:17:38 +01:00
|
|
|
deps = bindep
|
|
|
|
commands =
|
|
|
|
bindep test
|
2018-03-22 16:40:29 -04:00
|
|
|
|
|
|
|
[testenv:lower-constraints]
|
Correct lower-constraints.txt and the related tox job
In the review of a similar change in placement [1], it was realized that
the nova lower-constraints tox job probably had the same problems.
Testing revealed this to be the case. This change fixes the job and
updates the related requirements problems accordingly.
The are two main factors at play here:
* The default install_command in tox.ini uses the upper_contraints.txt
file. When there is more than one constraints.txt they are merged and
the higher constraints win. Using upper and lower at the same time
violates the point of lower (which is to indicate the bare minimum
we are capable of using).
* When usedevelop is true in tox, the command that is run to install the
current projects code is something like 'python setup.py develop',
which installs a project's requirements _after_ the install_command has
run, clobbering the constrained installs. When using pbr,
'python setup.py install' (used when usedevelop is False) does not do
this.
Fixing those then makes it possible to use the test to fix the
lower-constraints.txt and *requirements.txt files, changes include:
* Defining 'usedevelop = False' in the 'lower-constraints' target and
removing the otherwise superfluous 'skipsdist' global setting to
ensure requirements aren't clobbered.
* Removing packages which show up in lower-constraints.txt but not in
the created virtualenv. Note that the job only runs unit tests, so
this may be incomplete. In the placement version of this both unit and
functional are run. We may want to consider that here.
* Updating cryptography. This version is needed with more recent
pyopenssl.
* Updated keystonemiddleware. This is needed for some tests which
confirm passing configuration to the middleware.
* Update psycopg2 to a version that can talk with postgresql 10.
* Add PyJWT, used by zVMCloudConnector
* Update zVMCloudConnector to a version that works with Python 3.5 and
beyond.
* Update olso.messaging to versions that work with the tests, under
Python 3.
* Adding missing transitive packages.
* Adjusting alpha-ordering to map to how pip freeze does it.
* setuptools is removed from requirements.txt because the created
virtualenv doesn't contain it
NOTE: The lower-constraints.txt file makes no commitment to expressing
minimum requirements for anything other than the current basepython.
So the fact that a different set of lower-constraints would be present
if we were using python2 is not relevant. See discussion at [1].
However, since requirements.txt _is_ used for python2, the
requirements-check gate job requires that enum34 be present in
lower-constraints.txt because it is in requirements.txt.
NOTE: A test is removed because it cannot work in the
lower-constraints context: 'test_policy_generator_from_command_line'
forks a call to 'oslopolicy-policy-generator --namespace nova' which
fails because stevedore fails to pick up nova-based entry points when
in a different process. This is because of the change to usedevelop.
After discussion with the original author of the test removal was
considered an acceptable choice.
[1] http://eavesdrop.openstack.org/irclogs/%23openstack-dev/%23openstack-dev.2019-03-05.log.html#t2019-03-05T13:28:23
Closes-Bug: #1822575
Change-Id: Ic6466b0440a4fe012731a63715cf5d793b6ae4dd
2018-12-05 14:01:04 +00:00
|
|
|
usedevelop = False
|
2018-03-22 16:40:29 -04:00
|
|
|
deps =
|
|
|
|
-c{toxinidir}/lower-constraints.txt
|
|
|
|
-r{toxinidir}/test-requirements.txt
|
|
|
|
-r{toxinidir}/requirements.txt
|