88ec22f606
Argument 'retcode_only' of the function and associated logic was removed as it was not beneficial to the purpose, or use of the function. Before this patch, only call of the function setting 'retcode_only' to 'True' was made in tests of the tripleoclient. All other calls worked with assumption that Bool, not object will be returned, and didn't supply the argument explicitly. Instead relying on the default value. In addition, it is not clear how would the Popen[0] object be used, if it was returned. The function has limited impact across Openstack[1], only calls to it are made within tripleoclient, although there is a homonymous function withing validations_libs[2] intended for a same task. Docstring and tests were adjusted accordingly. Minor docstring typo was fixed. [0]https://docs.python.org/3/library/subprocess.html#popen-objects [1]https://codesearch.openstack.org/?q=run_command_and_log&i=nope&literal=nope&files=&excludeFiles=&repos= [2]https://opendev.org/openstack/validations-libs/src/branch/master/validations_libs/utils.py#L607 Signed-off-by: Jiri Podivin <jpodivin@redhat.com> Change-Id: Ie735ed470966a976940aefc8f99b106699080a83
About tripleoclient
General information
tripleoclient is an OpenStackClient (OSC) plugin implementation that implements commands useful for TripleO and the install and management of both an undercloud and an overcloud.
See the TripleO Documentation for details on using tripleoclient.
See the Release Notes
Team and repository tags
