The existing unit test case [1] is failing randomly [2]
when both test modules `test_plugin` and `test_monitoring`
runs in a single worker.
Reason: VNFMonitor class is using singleton pattern.
In above test modules same object of VNFMonitor class
is returned from __new__ method but internally it makes
a call __init__ explicitly.
Since we are not initializing `_hosting_vnfs` attribute in
the __init__ method, when we try to access __hosting_vnf in
the second test `test_plugin`, it finds two vnf objects.
This issue is fixed in this patch by reinitializing the
`_hosting_vnfs` class level attribute as empty dict in the
test_init_monitoring unit test.
[1]: https://github.com/openstack/tacker/blob/master/tacker/tests/unit/vnfm/test_plugin.py#L75
[2]: http://logs.openstack.org/10/609610/9/check/openstack-tox-py35/b99de12/testr_results.html.gz
Change-Id: I2a5933ed21e478e860cb12b378a4368f9402291d
The commands used by constraints need at least tox 2.0. Update to
reflect reality, which should help with local running of constraints
targets.
Change-Id: I220127ff324719ed0b824b2288273bfd849182e0
Earlier tox -efunctional command was running unit tests
instead of functional.
This issue is fixed in this patch by explicitly pointing
to functional test code path.
Closes-Bug: #1778698
Change-Id: Ib98b667188fe3245a5ad4a140c0d3b2d3378ef84
Create a tox environment for running the unit tests against the lower
bounds of the dependencies.
Create a lower-constraints.txt to be used to enforce the lower bounds
in those tests.
Add openstack-tox-lower-constraints job to the zuul configuration.
See http://lists.openstack.org/pipermail/openstack-dev/2018-March/128352.html
for more details.
Co-Authored-By: Nguyen Hai <nguyentrihai93@gmail.com>
Change-Id: Ida2bb7e0de8ca646af2da8c4bc3ed1708f69b184
Depends-On: https://review.openstack.org/555034
Depends-On: https://review.openstack.org/558566
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
When we run tox -e py27 command and after that
we run tox -e py35 command, we will meet with
test fail problem like: "No module named gdbm".
This patch adds cleaning up of this file
before running next tests.
Change-Id: I35a20521706b19a3067a5579c9dcf46efd0d55c0
Remove setuptools-git its not required to run the unit tests.
Change-Id: I3838a9c90e45862cc53eb1f71033d7a665991887
Signed-off-by: Chuck Short <charles.short@ericsson.com>
The gate-test-requirements job is doing the same thing.
We cannot use revert since it is breaking the gate-test-requiremnts job.
Change-Id: Ie5f4304b0cb59fda9bcc87df518e4c2ad9915b60
In this patch, a tool is provided for team to do the sync to avoid
any gaps with global requirements.
Change-Id: Ie960eae7a2756aa0f267c8ad37ea60f5effe6742
Partial-bug: 1668848
The gating on python 3.4 is restricted to <= Mitaka. This is due to
the change from Ubuntu Trusty to Xenial, where only python3.5 is
available. There is no need to continue to keep these settings.
Change-Id: Ib94f0f269173072b5a4c77d46b43852e78092487
Remove unnecessary commands in 'testenv:cover' of tox.ini.
HTML coverage reports can be generated in 'cover' directory by
'python setup.py testr --coverage' only.
Change-Id: I6bc205c4a7772a11cd3dc911a52097e62444376f
Closes-Bug: #1651029
This patch is the first step to bring the NFV Orchestration
API Reference to the repository.
It is a part of the effort described here [1]:
[1] https://wiki.openstack.org/wiki/Documentation/Migrate#API_Reference_Plan
Once this skeleton patch is merged, an api-ref job can be added to
the gate. The gate job makes it much easier to review API Reference
contents, which will be brought by follow-on patches.
Change-Id: I7cc587f2c7b3c546be9cd11bad7e3b4eeacad171
Co-Authored-By: Naoya Harada <n-harada@vx.jp.nec.com>
Openstack infra now supports upper constraints for
all jobs. Updated tox.ini to use upper constraints
for all jobs.
Change-Id: Ibd2c90826db6d07193e3f01c25cb49ee9994b404
Closes-Bug: #1614361
The *openstack/common* was used to keep codes from oslo-incubator,
but oslo-incubator was ignore in oslo3.11.0. So I think we
needn't use it any more.
Here is the oslo.utils CHANGES link:
http://docs.openstack.org/developer/oslo.utils/history.html
Change-Id: Ia8f46f8192bed49a7a7d71103c45a6ca5d2f6012
It also make required keystone config changes as part
of devstack plugin, which helps the functional test cases
to successfully complete and it makes inline with existing
tacker conf.
Closes-bug: #1592247
Change-Id: I545ceb2c9e61c22dbd8a0e1ee39a6e4fa24f8e88
Also, we move tacker.i18n into tacker._i18n.
Other i18n usage integration will be done by bug 1599735
Change-Id: I742f7be08958337720056bcc4344dcdc06606035
Partial-bug: #1552282
To make patches small and easy to review, the task (using oslo) is
implemented in a series of patches.
In this patch, some codes under tacker/openstack/common are changed
temporarily, but they will be removed totally in later patches.
Change-Id: I5396e8e569ff8b26b387e99f2442ccfa3f27d684
Partial-Bug: #1552282
Parallel execution of tacker functional test ends up
creating lots of VMs and eventually fails hitting the
default max instance of 10. This fix disables quota for
tacker functional test suite. However gate VMs still has
upper constraint on resources like 8GB max limit. To avoid
tripping the actual gate VM resource limit reduce concurrency
to a lower number (2).
Change-Id: I3fe8c012b85554fa21b5b4b64378d68e3d979cc2
Closes-Bug: #1572420
Test classes were being accounted for during coverage, they
are now ignored for more accurate coverage metrics. Remove
references to neutron in .coveragerc. Fix tox.ini coverage
entry.
Co-Authored-By: Larry Rensing <lr699s@att.com>
Co-Authored-By: Sridhar Ramaswamy <srics.r@gmail.com>
Change-Id: I92d50592a5ba43f68554aa933ab8582897b58b43
Fix the post_test_hook.sh and tox.ini to use right tox enviroment.
Post_test_hook.sh collects the result reports.
Change-Id: Ie60cd55521d89cb2e00f3ecff0fe3af989e0f6ea
Closes-bug: 1559861
There's no need to have an outdated translation file checked in that
has no content besides metadata. For translations, the full file would
be needed which can easily be generated.
Adjust tox test so that it passes if no translations are in tree.
Change-Id: Ib1a7abf211ed8af515ae462fce845a028d577101
This Patch fixes pep8 errors and
enables this tests for all new patches to tacker.
E125 continuation line does not distinguish itself from next logical line
E126 continuation line over-indented for hanging indent
E129 visually indented line with same indent as next logical line
H302 import only modules
H904 Wrap long lines in parentheses instead of a backslash
see OpenStack Style Guidelines
http://docs.openstack.org/developer/hacking/
Change-Id: I29e8ac8e6cfcd547e9bdab599635d07f0df6e3d6
Related-Bug: 1515930
This Patch fixes all E713 and F811 errors and
enables this test for all new patches to tacker.
E713 test for membership should be ‘not in’
F811 redefinition of unused variable
see OpenStack Style Guidelines
http://docs.openstack.org/developer/hacking/
Change-Id: I2f73c11bb5f89b3d3c2a85417ad5098fd21e580d
Related-Bug: 1515930
This Patch fixes all E265 errors and
enables this test for all new patches to tacker.
E265 block comment should start with ‘# ‘
see OpenStack Style Guidelines
http://docs.openstack.org/developer/hacking/
Change-Id: I4b1234fab420174d99b2c13a5b25c1f7c5d4909f
Related-Bug: 1515930
This Patch enables this tests for all new patches to tacker.
F402 import module shadowed by loop variable
F812 list comprehension redefines name from line
H237 module is removed in Python 3
see OpenStack Style Guidelines
http://docs.openstack.org/developer/hacking/
This patch cleans up py26 and py33 references,
because it is just necessary to test py27 and py34.
see
http://governance.openstack.org/reference/cti/python_cti.html
Change-Id: I7b225f6939f553b06ba84d01ccbdecf41b1a910a
Related-Bug: 1515930