openstack
/
tempest
Code Issues Proposed changes

Merge "Add 'single core approve' policy for plugins sanity jobs failure"

This commit is contained in:
Zuul 2019-09-25 03:55:51 +00:00 committed by Gerrit Code Review
parent e227022df9 2096631932
commit 1d11c5d696
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
REVIEWING.rst
View File

@ -183,6 +183,9 @@ When to approve
* the project's PTL +1's the change
* the patch does not affect any other project's testing gates
* the patch does not cause any negative side effects
* If fixing and removing the faulty plugin (which leads to fail
voting ``tempest-tox-plugin-sanity-check`` job) and unblock the
tempest gate
Note that such a policy should be used judiciously, as we should strive to
have two +2's on each patch set, prior to approval.