Update patch set 8

Patch Set 8: Code-Review-1 (1 comment) Patch-set: 8 Label: Code-Review=-1
2018-01-22 03:21:05 +00:00
parent 88e4e225db
commit ccff42c130
1 changed files with 21 additions and 0 deletions
--- a/21
+++ b/21
@@ -0,0 +1,21 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "7f96bb07_1f2060f7",
+        "filename": "os_xenapi/cmd/bootstrap.py",
+        "patchSetId": 8
+      },
+      "lineNbr": 33,
+      "author": {
+        "id": 17920
+      },
+      "writtenOn": "2018-01-22T03:21:05Z",
+      "side": 1,
+      "message": "I guess this should be in the main function instead. Otherwise it will invoked at anywhere import this module. e.g. it may break the UT if UT env is not allowed to create new the log file?",
+      "revId": "a87d16097269e1ea0f7b07ed5c9323c80652fbd5",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}