12930 Commits

Author SHA1 Message Date
Kevin Benton
9390dde943 make floating IP specification test robust to races
The get_unused_ip function returns an address that isn't in use on
the network at the time it's called. However, by the time the caller
uses it, it may have been allocated to another concurrent test if
the network is shared or external.

The test_create_floatingip_with_specified_ip_address test creates
a floating IP with an unused IP on the external network, which has
lots of activity on it from other tests so it would occasionally
have its address taken by another test.

This patch just catches the in use error and tries again with a
new IP.

Change-Id: I5a2f78a6da1e400dea07949f35964abb767edbb2
Closes-Bug: #1532033
2016-01-10 23:18:15 -08:00
Kevin Benton
8e54248653 Allow get_unused_ip method to skip v6 and fix iter
Skip IPv6 subnets when looking for an unused IP in the
floating IP tests since floating IPs cannot be requested
with v6 addresses.

This also fixes the iterator for the non-allocation pool
case.

Closes-Bug: #1531706
Change-Id: Id0b2c28970ab61e45755818e3e0798daa4453ce7
2016-01-06 13:27:54 -08:00
Jenkins
3bcc1c3d4c Merge "Separate the command for replace_port to delete and add" 2016-01-07 04:50:56 +00:00
Jenkins
dec01b8583 Merge "ovs_vhostuser: fix vhostuser_socket_dir typo" 2016-01-07 01:37:36 +00:00
Jenkins
5b0c20ebe4 Merge "Remove openstack.common._i18n from Neutron" 2016-01-07 01:37:12 +00:00
Jenkins
ecc108caa8 Merge "Revert "Revert "Revert "Remove TEMPEST_CONFIG_DIR in the api tox env"""" 2016-01-06 20:48:14 +00:00
Jenkins
bf11ed7430 Merge "Introduce an API test for specified floating ip address" 2016-01-06 20:45:05 +00:00
Jenkins
dc0706b534 Merge "Don't snat traffic between fixed IPs behind same router" 2016-01-06 20:44:40 +00:00
Jenkins
37a9594aa4 Merge "Remove l2pop _get_port_infos method" 2016-01-06 20:44:19 +00:00
Jenkins
8dc59c82b3 Merge "Fix meter label rule creation" 2016-01-06 20:44:00 +00:00
Jenkins
9c5a25b141 Merge "SR-IOV agent: display loaded extensions" 2016-01-06 20:43:11 +00:00
Jenkins
02d7e99d90 Merge "Imported Translations from Zanata" 2016-01-06 20:40:39 +00:00
Ihar Hrachyshka
380e384f18 Revert "Revert "Revert "Remove TEMPEST_CONFIG_DIR in the api tox env"""
This reverts commit be63289c273fa02159a6958e0b456d5fda217431.

Yes, it's a third order revert. Ain't it cool?

Now that tox 2.3.1 is used in gate, and it is expected to fix the issue
that we originally hacked around here, let's revert to the previous
code.

For the least, it makes API target executable locally without the need
to set TEMPEST_CONFIG_DIR in the external environment.

Also bump minimal tox version to 2.3 to avoid users hitting the old
issue with their tox 2.2.* package.

Change-Id: Ic64cb466d117ad39436cb1d079c8f5657260da2c
Related-Bug: #1515335
2016-01-06 16:14:26 +00:00
Jenkins
25a9f6eec3 Merge "Add extension_manager and support for extensions in linuxbridge agent" 2016-01-06 15:12:58 +00:00
Yu Fukuyama
6659a93558 Fix meter label rule creation
In the case of outbound traffic, set remote_ip to dst.
In the case of inbound traffic, set remote_ip to src.

Change-Id: I7f27b93efa67baf3efccaa94f6a1337d6886e230
Closes-Bug: #1528137
DocImpact: Clarify remote_ip_prefix description of metering label rule in API site
2016-01-06 14:08:07 +00:00
Jenkins
89fa5b997a Merge "Add test for Neutron object versions" 2016-01-06 13:35:44 +00:00
Assaf Muller
494ee39c6f Remove l2pop _get_port_infos method
It's a method called 'get_port_infos' that returned
4 values, most of which were not a function of the port.
What the method did or its naming was very unclear to me
so I broke it up according to its usage.

Change-Id: Ib1fd589e9123fc5009f0887dd400c550efa687a3
2016-01-06 13:17:36 +00:00
Jenkins
70606fa29a Merge "Some minor misspellings in comment block." 2016-01-06 10:56:17 +00:00
Martin Hickey
074268f74c Add test for Neutron object versions
Adds a test to Neutron to check object versions for any changes
to objects. It prompts the developer to update the version of the
changed object. It uses oslo.versionedobjects.

Change-Id: I99454b28ae0b5fa663354eeccdf709d4030a280b
Co-Authored-By: Ryan Rossiter <rlrossit@us.ibm.com>
2016-01-06 10:34:03 +00:00
Moshe Levi
66a91c6c38 SR-IOV agent: display loaded extensions
The SR-IOV agent support l2 agent extension due to
this patch https://review.openstack.org/#/c/210483/

This patch allow to show the loaded l2 agent extensions
when executing neutron agent-show <SR-IOV agent id>

Closes-Bug: #1527307
DocImpact update the agent configuration to show
          l2 agent extensions
Change-Id: I5dcb79ef539e4f18693e4a8eff03fff40873d3fa
2016-01-06 10:45:09 +02:00
OpenStack Proposal Bot
35cd834c37 Imported Translations from Zanata
For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: Icca45cc80c0481a7bc500b8409aaa0948ba5daa2
2016-01-06 06:29:46 +00:00
Jenkins
b01e3084d1 Merge "Delete test_restart_l3_agent_on_sighup" 2016-01-06 04:11:05 +00:00
Sławek Kapłoński
23e0e29a2b Add extension_manager and support for extensions in linuxbridge agent
There is extensions mechanism for l2 agents already but it was
implemented only for openvswitch l2 agent. This patch adds support for
such extensions also for linuxbridge agent.

This patch also adds support for network_update events received by the
agent via RPC. It is required because sometimes when a network is
updated (for example with a QoS policy is attached to it) all ports that
belong to the network should also be updated.

Change-Id: Ie81c818d0eb817b044a6df1cbddc5864f118fe3f
Partial-bug: 1468803
2016-01-05 12:38:11 +00:00
Assaf Muller
218b5d06f5 Fix API tests
Patch https://review.openstack.org/#/c/256164/
broke the Neutron API job by unsetting Tempest configuration
values that were unused by Tempest, but used by Neutron's fork
of Tempest. This patch copies credentials from the 'auth' section
to the 'identity' section.

The longer term plan is detailed here:
https://etherpad.openstack.org/p/neutron-tempest-defork
TL;DR: Removed overlap of tests between the Tempest and Neutron
repos, then use Tempest's plugin architecture for the tests that
will remain in the Neutron repo.

Change-Id: Ieb396cfd17f9cb66776ead11e7f760c1c26a0b08
2016-01-05 10:41:44 +00:00
houming-wang
93aeb99b79 Remove openstack.common._i18n from Neutron
Since oslo-incubator is no longer maintained[1] after
90ae25e38915cc502d9e9c52d59e8fb668a72ae1. And
openstack/common/_i18n.py is not referenced by Neutron. Let's remove it.

[1] http://lists.openstack.org/pipermail/openstack-dev/2015-November/
    079343.html

Change-Id: Ia81d30d9722a5cc7d6ad21b0cbb27df8cd80c848
2016-01-04 17:58:46 +00:00
Jenkins
0c07378509 Merge "dhcp: Default to using local DNS resolution" 2016-01-03 13:34:31 +00:00
OpenStack Proposal Bot
95414bcfd4 Updated from global requirements
Change-Id: I721b27b36b21447161a34a6cf6788eac6dd145fc
2016-01-01 20:29:56 +00:00
Jenkins
e3468ed8a2 Merge "Misspelling in message" 2015-12-31 11:50:13 +00:00
Herman Ge
42e51bf06f Misspelling in message
Misspelling in following message:
"# interconnect physical and integration bridges using veth/patchs".
Should be:
"# interconnect physical and integration bridges using veth/patches".
Totally 1 occurrence in Neutron base code.

Change-Id: If752b8c65cf4993447b93dfc9a06de15389f2675
2015-12-31 09:08:18 -05:00
watanabe isao
8f036fd340 Mitigate restriction for fixed ips per dhcp port
When number of fixed ips per dhcp port exceeds max_fixed_ips_per_port,
a dhcp resync will be triggered.

The bug report stated how simply this issue can be triggered.
Moreover, "max_fixed_ips_per_port" value should be used for non-DHCP
port only and DHCP port is not affected by this parameter.

Change-Id: Iaa9ed6949383ba6a7ce0b3ffd9dcced663126317
Co-authored-by: NGUYEN TUONG THANH <thanhnt@vn.fujitsu.com>
Closes-Bug: #1179713
2015-12-31 17:01:00 +07:00
Jenkins
d8a57788a1 Merge "Wrong usage of "an"" 2015-12-30 20:22:48 +00:00
Jenkins
8b66198033 Merge "Wrong usage of "a"" 2015-12-30 20:15:01 +00:00
Kyle Mestery
0de1d8d4ca dhcp: Default to using local DNS resolution
It's pointless to not include default DNS resolution for Neutron.
This adds a new config option (dnsmasq_local_resolv) which defaults
to 'True' and will allow for DNS name resolution to work out of
the box. The caveat is that if the 'dnsmasq_dns_servers' is set it
will override the 'dnsmasq_local_resolv' setting, thus allowing
operators to explicitly set their own DNS servers.

DocImpact: Default to using local DNS resolution with the DHCP agent.

Change-Id: I17a884f467d307432a06f67a9dd93ed2fa6081a3
Closes-Bug: #1466117
Signed-off-by: Kyle Mestery <mestery@mestery.com>
2015-12-30 12:06:16 -06:00
shihanzhang
cb3c6fe8a9 Remove unused variable use_call in ovs-agent
The patch Id28248f4f75821fbacf46e2c44e40f27f59172a9 makes agent
always reporting its state with RPC call() method, so the variable
self.use_call was unused, this patch removes it.

Change-Id: I2e15d9ea2f35dce710858db8c8c6efd8c8304a23
2015-12-30 15:55:35 +08:00
hgangwx
0995ebda7f Wrong usage of "an"
Wrong usage of "an" in the messages:
"Gets called when an port gets added to or removed"
"Create an command to add an OVS bridge"

Should be:
"Gets called when a port gets added to or removed"
"Create a command to add an OVS bridge"

Totally 2 occurrences in Neutron base code.

Change-Id: I40756ed3eff7d2f672b2e0203b59ea5b8ff224c3
2015-12-30 01:15:56 +08:00
hgangwx
283e5db691 Wrong usage of "a"
Wrong usage of "a" in the messages:
"'%s' is not a integer"
"Create a address scope"
"Return True if port has as a allowed address pair"
"But if a agent does not report its status"
"a ipv4 link-local address"
"Retrieve and return a extended information about a network"
"It could be a eui-64 address, a random IPv6 address"
"push a elastic-recheck query for it (see below)"
"is not a enforced requirement"
"a ovs_lib.VifPort object"

Should be:
"'%s' is not an integer"
"Create an address scope"
"Return True if port has as an allowed address pair"
"But if an agent does not report its status"
"an ipv4 link-local address"
"Retrieve and return extended information about a network"
"It could be an eui-64 address, a random IPv6 address"
"push an elastic-recheck query for it (see below)"
"is not an enforced requirement"
"an ovs_lib.VifPort object"

Totally 9 occurrences in Neutron base code.

Change-Id: I0f980fc8c98524db3d194ecb779f76abb37eb31c
2015-12-30 01:15:16 +08:00
Jenkins
a6547e9cf0 Merge "Change log level from error to warning" 2015-12-28 19:20:18 +00:00
Jenkins
f7e2a4080c Merge "Allow to control to use constraint env for functional jobs" 2015-12-28 12:12:39 +00:00
ChangBo Guo(gcb)
06174a41e4 Trival: Remove unused logging import
Change-Id: I13298e642f25c9f70dcff9b1e056b418edf0a461
2015-12-26 12:49:56 +08:00
Jenkins
550ab90c1b Merge "Add tests that constrain db query count" 2015-12-25 16:34:32 +00:00
Akihiro Motoki
477b390b32 Allow to control to use constraint env for functional jobs
VPNaaS functional tests now use dsvm-functional instead of
*-constraints. Always assuming *-constraints breaks the functional
jobs which is not run in a constrainted environment yet.

Paritial-Bug: #1529027
Change-Id: I3a4f1d61d13f1e444f7624d68d121d04d81eb724
2015-12-25 23:40:22 +09:00
Jenkins
f95dce7785 Merge "Correct state_path option's help string" 2015-12-25 04:52:54 +00:00
Jenkins
904cdc723b Merge "Ignore non rules related qos_policy changes" 2015-12-24 09:00:54 +00:00
Jenkins
1a74e569f2 Merge "dibbler: fix import order" 2015-12-24 08:17:49 +00:00
zoukeke@cmss.chinamobile.com
2631a495d8 Change log level from error to warning
The service respawning action of ProcessMonitor is normal handling. So
the log level in external_process.py should not be error.

Closes-Bug: #1528850
Change-Id: Ie335f521b09310a577eb4fb03946dfba484eef61
2015-12-24 12:51:26 +08:00
Jenkins
1a0cbdff78 Merge "Return availability_zone_hints as list when net-create" 2015-12-24 04:12:53 +00:00
Jenkins
bf9e4133eb Merge "Add address scope to floating IPs in RPC response to L3 agent" 2015-12-24 00:07:41 +00:00
Jenkins
6dc9a79579 Merge "reject leading '0's in IPv4 addr to avoid ambiguity" 2015-12-23 23:04:40 +00:00
Jenkins
d6287bd5c5 Merge "Add constant to L3 extension for floating ips" 2015-12-23 21:38:35 +00:00
Jenkins
623a2ff0d8 Merge "API: _validate_ip_address should not raise an exception" 2015-12-23 19:42:48 +00:00