There are multiple problems with it:
* the --reviewers options works differently, as it should be added only
once and then listed the emails
* in case of dummy contacts or not registered contacts the git-review
command fails
Since we have already a script [1] to add reviewers to *every* open
patch, it is easier to run that *after* we finished the bulk uploading
of patches.
[1] tools/add_reviewers.sh
Change-Id: I2942033134adb30db0cd7e955f7bf8aefbbb3c5b
When running this bulk command it is always good to double check what
we are pushing to gerrit. This patch shows the commit message with
changed files list with 'git show --stat' command and then waits for an
Enter. This also makes it more visible if a git push has failed.
Note: when aborting the script the branches will remain in our local
git repository and that needs to be cleaned if we want to run the
script again. Though this is also valid if we don't cancel the script.
Change-Id: If23202be15493d2ac9bccd3e2d1af04395b18a23
These teams are PTL-less and not necessary define their
release liaison in openstack/release/data/release_liaison.yaml.
The problem is that their release liaison approval is not
necessarily detected.
These changes allow to consider these release liaisons folks.
Furthermore, patch Id0d6eeaf66394806374781d1cf26c087a6e90f87,
from the similar script in project-config repository, also applied
here in this script to avoid exception in case of DPL teams.
Change-Id: Ieaf1eafc6a8e3ce443d73876e525f738e51dea67
Without knowing which releases have been made within the given
series either we shoots in dark in choising the kind of release
(bugfix, feature, major, etc...) or we need to check manually
what are the existing versions. That's time consuming.
These changes simply display the current versions available in
the given series.
Change-Id: Idb160198d52d3bc6b0fa00095b143b19a1f130eb
clone_repo script does not fail if the branch does not exist, but
checks out the master branch [1], so we have to make sure the required
branch exists.
This patch also adds a check that there were no more patches merged
after the given branch was tagged EOL.
[1] https://opendev.org/openstack/releases/src/branch/master/tools/clone_repo.sh#L187
Change-Id: Ia1ededfc3cebbae807719750dc5e2d5949ce9a21
The branch to use in process_auto_release is determined by the
branch linked to a series's status, however, at some point during
a series projects are branched and the status isn't yet updated
so used branch refer to master, and so, to the next series.
During the final-rc delta of changes between RC1 and RC2 is
retrieved from master, which is wrong.
These changes allow to choose another branch if needed.
The default used branch will remain the series retrieved
by status.
Change-Id: Iff8df80aa6f3ba67c04e0674d7c72474f3a4e73a
Some traiing projects follow the cycle-with-rc model however our doc
and our tools doesn't differentiate them during RC1. These project
doesn't have to be released during RC1. These changes adapt our process
accordingly.
Change-Id: I44040bc040f19a75c468d385395323fe0a1f459a
This patch adds a question whether to delete a stale eol branch if it
does not contain open patches.
The deletion is done via Gerrit API, which requires 'delete reference'
access category for the user who is running this script.
Change-Id: Iea33c2bd4bd20dd0f92fd9a7e12008d841176974
This tool will be used in doc addition around the branching period
to ensure that we don't miss to create stable branches for project.
Also this tooling should be used around each trailing deadline to ensure
to not forget a trailing projects. Trailing projects are those who can
easily meet the conditions that lead to forget to branch them.
Adding usage of this tooling in our process to ensure to check that
point once a time at each new series.
Change-Id: I2a8bd25ecfe5bb1bde5af16b08f897a5bdc11cb7
When generating release patches with process_auto_releases.sh it could
be useful to have the list of changes in the commit message of the
release patch. This patch adds an extra question for that.
Change-Id: I8f26fb5655ef1cd280b243cadbb7b49d596e7d51
Since transition from the EOL model to the EM model eol branches
are no longer removed and this step is no longer in the release team
process.
Keep stale branches can be an issue in some situation especially with
zuul and our gates. To avoid this situation the release team propose
to reintroduce regular checks to ensure that we remove stale branches
that have been tagged eol previously.
As discussed during our previous meetings soon it will be possible to design
a new job and to trigger it to remove eol branches automatically.
This will possible when the infra would have been updated and when all
the needed pieces will be in place.
Change-Id: I53aeb3211bb3251a3278472a514a39afe825cdd2
The release team has a few cases now where we need to propose release
patches for a large set of deliverables. Due to differences in semver
choice based on actually merged commits, along with other decisions that
need to be made while doing these, this process can't be completely
automated. But this adds a script that will automate the majority of the
process to simplify it as much as possible.
Change-Id: I6ec9fa77baab58df93bdadc0ac3c3fa5d3e18804
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
This updates the version of hacking we are using for our linting and
addresses various issues that the latest version flags.
Change-Id: I95ed73411e96451bc447e1b5858b0466fb8f10a9
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
The load() call from PyYaml is considered a higher security risk in that
it uses the FullLoader. safe_loade() is considered more safe by using
the SafeLoader instead.
Since the 5.1 release of PyYaml added warning output when using load(),
this switches over to safe_load() to avoid the unnecessary noise.
Change-Id: I1949deed094822d2c2c56659eadb1fc5ea6a59e5
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Rewrite list_unreleased_changes as python format and add new features.
By default it will behave as the previous version of this command (the
shell script).
Few new feature have been added in these changes to allow us to more
easily handle outputs in scripts.
Features added:
- allow user to retrieve results in json format
- allow user to retrieve results in yaml format
- allow user to ignore project not yet released
The shell script entry-point (tools) is still there but it will call
the python command in a venv instead of directly implement features.
Also the python version allow us to more surround this tools with unit tests.
Change-Id: Iaf86ecb1589c40102acb621b23ea12d71ed453bb
This updates the script to not require a specific topic to make it
easier to automate a job that periodically makes sure all open reviews
have had the PTL and liaison added.
Also refactored the adding of teams because bash array handling can be a
bit wonky sometimes and not always append values. This makes sure no
teams are skipped.
This is slightly less optimized for large reviews like the final series
release since it loops through teams based on the deliverable files. As
a slight optimization, it will skip a team if it was the same team as
the last deliverable file. It just might be possible that the same team
will be processed multiple times if their deliverable files are not in
alphabetical order, but there is no harm in that other than taking
slightly longer to complete.
Change-Id: I9a9194ea276aa0120aef21a321f48a93419fb848
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
If we miss something with this command we need to get the
python script's help to get how to use this tools, these changes
add the command to execute through the wrapper to get this help.
Change-Id: I1e9fceece6fee40722e21e49ca5689faacefdf93
If we run in CI, rather than prioritizing using 'python setup.py --name'
as the project name to be used in release announcements, use the
repository name as provided by Zuul.
This should fix the issue reported in:
http://lists.openstack.org/pipermail/openstack-discuss/2020-April/014359.html
Change-Id: Ia0026356676561a6b3a55ab05db5ed7a58b646b6
This adds a script that will go through all release reviews under a
given review topic, find the PTL and release liaisons for the owning
teams of those releases, and add them as reviewers to the patch.
Change-Id: I6294c1d9da7d6a977df6d8460aa085d2cc7e72a5
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
We are taking down coreos-image-builder since it
was never really used, and left abandoned.
More information on this can be found at:
https://review.opendev.org/#/c/707181/
Change-Id: Idb42353f86f192cc8ff2defbbae71e7df76702c6
get-contacts:
To extract the PTL/Liaison contact information from the governance data
/ release team data
tools/bulk_review.sh:
To manipulate a dirty working-tree and post as a single gerrit topic,
one change per team. Changes are unordered so any change can be merged
when it's ready/ approved by the appropriate team
Also enhance get-deliverable-owner: to detect file paths
Story: 2005704
Task: 31028
Change-Id: Ia319e8a7b4da195cb4bc861c51025a41adc43bb3
Introduce a new tool to list inconsistencies between projects.yaml
in governance repository and deliverables in the releases repository.
Sometimes projects.yaml defines release-managed deliverables, but the
release team is not handling them. Sometimes, the release management
team handles deliverables which are not officially produced by an
OpenStack project team, and should probably not be listed on releases.o.o.
This tool lists both types of inconsistencies, and can be integrated
to release management process so that they are handled before becoming
an issue.
NB: Once ready, this tool could be used to replace the "membership
freeze check" tool which only looked at some of those inconsistencies.
Change-Id: Id263f0c91f872111fe997e2b8a1088b61033d114
Fixes some comments from the initial review and minor cleanup.
Change-Id: I17f18f63cb7e9da4bc7504405472e3ac39151c3e
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Git repo origins are now removed in CI jobs, so our detection of project
short name from looking at the git remote now fails. This resulted in
release announcements linking to "null" instead of the actual project
location [0].
This updates the script logic to detect if that is the case and fall
back to getting the repo name from the directory, which should be safe
in a CI job since there is no manipulation of the clones repo directory
name.
Also cleans up an unused variable that was left from a previous
refactoring.
[0] http://lists.openstack.org/pipermail/release-announce/2019-December/008306.html
Change-Id: I84e2cf258e9bc4541b7edde55a22a4be24bdb232
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Since the job will have to run on the Zuul executor, it needs to
only rely on stdlib, yaml and requests (which are already installed
on the executor).
Change-Id: Id4e5a88d352e95402d0899deceade6fed8146619
This is the first step into automating PTL/liaison approval.
This tool will check that PTL/liaisons either authored the change or
approved it.
Change-Id: I1bbb371997e9e92f39eff47adb4d3d176af35de7
At various stages we want to update lots of deliverables. This acts as
a tool to consolidate what we mean to supplement the docs and etherpad
Story: 2005707
Task: 31033
Change-Id: Ied1f6d06a33baf3d3ef3d789bbe5c7f70d967d62
Per best practices, explicitly use the python3 executable rather than
assuming the platform with have a "python" executable that maps to
python3.
https://www.python.org/dev/peps/pep-0394/
Change-Id: I39b8a1013a891f4570f374d8faa3cfa2ecaf3347
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
This updates the instructions for client and non-client lib freeze to
make sure all changes are captured in a final release. Also adds a
helper tool to separate out the two types of libs since they have
different deadlines.
Change-Id: I29ea73bcc5a9649d7d9c502ebc0a05c840e41484
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Running our default tox environments locally, the bashate tests fail
with several errors due to line length and indentation levels.
Change-Id: I15ec6a9cb1dbdb2200294c5aa2d2eb6074f00a25
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
There are many references to review.openstack.org, and while the
redirect should work, we can also go ahead and fix them.
Change-Id: I0d46b1a4e00c1775ea5e38d39e87bed99f6bbb2e
Probably mostly useful for extended maintenance, but this adds a script
that can add a $series-em tag to all deliverables of a series as we
claimed we would do in the extended maintenance policy changes [0].
[0] https://docs.openstack.org/project-team-guide/stable-branches.html#extended-maintenance
Change-Id: Ibeec88bf4e81b97c523f416669e07a10aa86a53b
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Simplify the instructions by providing a special script and then
update the instructions to refer to it.
Change-Id: Ibbcd422c06dc4aeb3df503f3c0f084b39d3bf0f7
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
