Some functions in api/neutron use @memoized decorator,
but @memoized decorator cannot handle request.GET (an instance of
QueryDict) because a weakref to WSGIRequest is not hashable.
(Note that @memoized decorator can handle a dict itself)
What we actually need is the content of request.GET.
By using .dict() method we can ensure arguments which
@memoized can handle are passed to api.neutron functions.
This pattern is used only in api.rest.neutron and
not used in other codes.
Closes-Bug: #1706348
Change-Id: Ibb38ad1d95af1cd90a1fedd834602f444010c151
During the recent work on release notes I got some useful lessons on reno.
It is worth documented. (Note that they will be added to the reno docs
but it is nice to have it in horizon doc too)
Also adds a link to the release note section in the contributor guide
to the release note page so that developers can find information on
the release notes more easily.
Change-Id: I0c5bd5f5e70d6c1be4eb8f8e895312205177774e
* Move a release note on SELECTABLE_THEMES from 'prelude' to 'fixes'
* Fix incomplete external link notation in
drop-settings-enable-fireall-vpn-fad7c1a4cd96df2b.yaml
* Update os-client-config URL affected by doc-migration
* Update neutron-fwaas-dashboard documentation URL
Change-Id: I8884bdfb22b33ddd8ca235c66e902d98cd24befd
reno includes release notes touched in a target release
even if they are added from past releases.
The recent release note cleanup I made as part of doc8 adoption
and some other cleanup touched release notes from past releases.
As a result, we see several number of release notes from past
release in the Pike release notes unexpectedly.
This commit ignores such release notes by using 'ignore-notes'
option introduced in reno 2.5.0.
The analysis detail is found at http://paste.openstack.org/show/617310/.
As a summary,
* ignore release notes from past releases touched by
commit c17a93af02167e5521945ce4c54be5c64a305a0f and
497cae2b57821bd0af4b51c5dbd53ddf67564206
* Ignore releasenotes/notes/glance-v2-ba86ba34611f95ce.yaml
updated by commit b01bf0f9a16b6aa48f73bf046e9ef51287cb40cc
as the commit is backported to Ocata during Ocata RC period
and released as part of Ocata 11.0.0 release.
Only exception is reorganise-access-and-security-ea7780aa9e7b83e7.yaml.
This file was added in Ocata but it was modified as part of Pike change.
It is really a bad idea to edit a release note of a past release,
but it is a different topic.
Change-Id: Iafe8365dca2a6ef963d7c459dab486975da939bc
Depends-On: Id3af7afb6396da4c3561241be8dd60276bd176e2
This commit updates links affected by doc migration.
Note that other links are not touched in this commit.
Fixing other broken links or changing http to https
should be covered by a separate patch.
Also convert http links to docs.openstack.org to https per reviewer
request (though it is not directly related to doc-migration).
Note that this commit does not touch files under releasenotes/notes/.
If we touch release notes in older releases, reno will considers
it as a release note in the current release.
(Pike release notes are clean up in a separate patch.)
Change-Id: Iba9bd465ef08014a4972584cf4da6e7d77961119
Currently on the angular images panel, edit image/update metadata/delete image
actions are only available for images created from the current logged in project.
This patch removed that restriction and added the policy check for the actions.
Change-Id: I17761e27f0659799d5e55e24a6106c3c7a3e5459
Closes-bug: #1698963
When using glance v2 client, it will leave an upload
tmp file in /tmp folder, which will cause upload error
if its filesystem (in memory) is full.
Change-Id: I0a7267db894e7be4216a346752d299132df9a29a
Closes-Bug: #1689694
If cinder not enabled, we cannot attach/detach volume for an instance.
So it's better not show the drop list.
Change-Id: I09578998c8f1a97bd24fb6043258b94e8f37bc09
Closes-bug: #1703511
Router creation template should contain the sentence based on the actual
use-case.
For example, if the router connected to the private network which has a
router already, the IP address has to be specified for the new router.
Change-Id: Ie9ddfba539369ab1035755fdf78bf55422952da4
Closes-Bug: #1707617
For the admin router view, list_l3_agent_hosting_router is called.
If this extension is not supported, it returns "resource not found"
and an error popup.
This api should not be called in case the extension is not supported.
Closes-bug: #1708081
Change-Id: I38f7386689d95dde3fc76bbf4d6b5e781b515878
1.As mentioned in [1], we should avoid using dict.iteritems()
to achieve iterators. We can use dict.items instead, as it will
return iterators in PY3 as well. And dict.items/keys will more
readable.
2.In py2, the performance about list should be negligible,
see the link [2].
[1] https://wiki.openstack.org/wiki/Python3
[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.htmls
Change-Id: Idba02079d76b529b344ae96cebb7d6161c0ecbc6
Required for Django 1.11 compatibility. Apparently
DynamicSelectWidget.render() receives it (through kwargs) and
tries to pass the parameter to its parent's method, but then
it fails (leading to exceptions in the rendering).
Closes-Bug: #1707660
Change-Id: I25e294a1c2f721a2f57dd50acb4c5e408b6187f9
