After a node is saved to the database, we weren't updating the
Node object to reflect what was saved. This caused a problem
where the node's update_at field was incorrect. It was fixed
in 065326c0f55a73c99706148f7bfbbec87ea863bc by explicitly
setting node.update_at. However, that doesn't address other
node fields that may be out of sync.
The more correct fix would be to do a similar thing that (most
of) the other Objects do, which is for the node to update itself
via ._from_db_object().
Doing this revealed several incorrect tests and code in the conductor
and agent where changes to the node's dictionaries were incorrectly
being set and thus, not being saved. Those are fixed in this patch.
Change-Id: Ia84cd60c1a4eabcc1ad0a756124c338fa9f644c8
Closes-Bug: #1679297
Related-Bug: #1281638
These were removed in 330ba8c502880a16db4d2673ab36358f559711ec but was
missing a release note. Add one in.
Change-Id: I34521c459805c8d4bce6830c0b31bd252df714fb
The method build_instance_info_for_deploy in
ironic.drivers.modules.agent was deprecated in the Ocata cycle
(7.0.0). It is no longer supported. The method
build_instance_info_for_deploy() from
ironic.drivers.modules.deploy_utils should be used instead.
Change-Id: I88dfb0b84709ca3545bb4d4384bfad58ec2eb0a0
Closes-Bug: #1678902
The ipminative driver was marked as unsupported on September 28, 2016,
and an email was sent to the list on March 9th, 2017 asking for
volunteers to run third-party CI to save the driver from deprecation.
Additionally, many ironic contributors who also deploy ironic have
reported instability while using this driver. For these reasons it's
being removed from the main ironic tree. If there are any users still
interested in this driver, they are invited to host it elsewhere.
Change-Id: I9bc9f4cbd916f040a636b967ec5556197ad3d8a8
Closes-bug: #1671532
The configuration option [ilo]/clean_priority_erase_devices was
deprecated in the Newton cycle (6.1.0). It is no longer supported.
The option [deploy]/erase_devices_priority should be used instead.
Closes-Bug: #1677449
Change-Id: Ib9110e9bd395d4a87aeb3981073530fb59949a47
Agent based deploy do not call boot.clean_up_instance() during node
teardown. This is required so that instance clean up can happen as
part of node teardown.
Change-Id: I6077b69f17ce462b6aae1b16fdb40158cf111c5e
Closes-Bug: #1676321
core_interfaces and standard_interfaces are both static members of BaseDriver
we need to take a copy of them before appending to them.
Change-Id: Ic6edc5e49a25849c7871dbc9e6e1d5a5eb229e57
Closes-Bug: #1672457
This commit updates the proliantutils version required in Ironic
to 2.2.1. This version of proliantutils includes HPSUM firmware
update support and updation of requirements to match
global-requirements (required to fix third party CI gate jobs)
Change-Id: Ife96638b6262d22b3aa82155df3d7e4f525bd22b
This patch ensure that there is no iscsi session left after
failed deployment.
Change-Id: I569933f27746da65b1d22ba9e9279439e2e792cf
Closes-Bug: #1632649
Nova dropped support for glance v1 in Ocata and we're going
to disable glance v1 in CI runs for Pike. The glance v1
API is deprecated so we should start burning it out of the
system in all of the projects.
Closes-Bug: #1670423
Change-Id: I1398f81b28e1b000ee110c159e498b72e3746109
Remove overwriting the default value of db_max_retries, instead use
default value defined by oslo.db which is 20.
Adjust the default value of db_max_retries in the release note and sample
configuration file.
Closes-Bug: #1671629
Change-Id: I1e5f632d687c1cebab895cc91958d502b9fce884
Introduces a new validation to ensure the node deallocation
process will only be performed to nodes that have Server
Profile applied in OneView. When the allocation process
fails, the machine will have no Server Profile applied in
OneView and in ironic it will have no reference to any
Server Profile. Under these conditions if the deallocation
process be performed the driver will try to delete a
nonexistent Server Profile in OneView, leaving the node
in error state in ironic.
Change-Id: I83cef7fafac4e22ebf5eb4fe83f6da26ec132c99
Closes-Bug: #1657892
An issue when it was impossible to update ``node.driver``
to classic if the current driver is one of hardware types.
Change-Id: I348a27a13d3025fe7e8ddfa31992b895a3809730
Closes-Bug: #1668579
Follow up patch of 3428cb74f0a6fe05c23cf00dc66da4c1d9766409
Add information about db_max_retries configuration option to the
release note. Add periods at the end of senteces in the release note.
Change-Id: I2811ce6976d020e32928773ecb872fefa05e10b7
This release note was updated in master after the ocata branch was cut.
Doing this caused it to appear in both ocata and current-series release
notes. Removing the file from master will prevent it from showing up in
master anymore.
Change-Id: Ic1c7ec1483e92e15a82392d87874c08a7a03b710
Closes-bug: #1670401
This is a follow up to I887a06566dcc2f09875f975f1e12ae4ff75fd348.
The release note tense is fixed, and more information is added about why
the change was necessary.
Change-Id: Ie89e21460a4a7654795830bf4781404ec506a52f
Moved fix-socat-command release note to a proper directory
ironic/releasenotes instead of ironic/ironic/releasenotes
Change-Id: If2b2a54ceb00c29ae81c9b7ca672f163b1985cb7
This patch enhances attach/detach logic and allows to work with
active ironic nodes. Starting with this change when VIF is attach/detach
neutron port is updated appropriately to reflect changes on hardware
(ie: plug port to specific network)
Change-Id: Idc9dc37b11950e3aa2864a0a90d6ec2e307926a3
Related-Bug: #1659282
Wrap all DB write operations with oslo_db decorator to retry on
deadlock. DBDeadlock exception can be raised quite often on Galera
clusters under load.
This also fixes an issue which causes conductor's periodic
tasks to stop executing.
Closes-Bug: #1637210
Closes-Bug: #1639338
Co-Authored-By: Vladyslav Drok <vdrok@mirantis.com>
Co-Authored-By: Joanna Taryma <joanna.taryma@intel.com>
Change-Id: I61db83637adfd98a5394d1f570f3de4302c93497
Liberty will never be released again, so I'm changing the 4.2.x to 4.2.5
(the last liberty release of ironic), as a followup to the
previous patch.
Change-Id: If38c01346282e1b9ea4fb2d5abfa010b8c27dba6
This patch adds notifications for create, update or delete
port groups. Event types are:
baremetal.portgroup.{create, update, delete}.{start,end,error}.
Developer documentation updated. "portgroup_uuid" field added to
port payload.
Closes-Bug: #1660292
Change-Id: I9a8ce6c34e9c704b1aeeb526babcb20a5b1261db
This release note is missing from the generated release notes
because the content was put in the 'upgrades' section; which
doesn't exist. This changes it to be in the 'upgrade' section.
Change-Id: I23cf5fa1a6797579c368fb4033e9be46f612ec1e
We apply specific rules when doing VIF attach, do not duplicate them
in vif_detach just walk over all port and portgroup objects.
This also fixes an issue when VIF was attached to port manually
(set vif_port_id key in port.extra) and it is impossible to detach
such VIF via v1/nodes/<node_ident>/vifs API.
Closes-Bug: #1663660
Change-Id: I70fe87bb4ae15a506fec705d10beaed572c0b45e
