1678 Commits

Author SHA1 Message Date
Zuul
97477c3261 Merge "User-friendly error message for DiscoveryFailure" 2022-05-06 17:07:04 +00:00
Zuul
2d40bf525d Merge "remove unicode from code" 2022-05-06 17:06:21 +00:00
Zuul
03a9dbb948 Merge "fix: miss attr _discovery_cache in ServiceTokenAuthWrapper" 2022-05-06 17:06:19 +00:00
Zuul
c69cc01b7b Merge "Use TOX_CONSTRAINTS_FILE" 2022-05-06 16:59:41 +00:00
Zuul
f9950b0ff3 Merge "bump py37 to py38 in tox.ini" 2022-05-06 16:55:12 +00:00
Ghanshyam Mann
7eeda4d9af Drop lower-constraints.txt and its testing
As discussed in TC PTG[1] and TC resolution[2], we are
dropping the lower-constraints.txt file and its testing.
We will keep lower bounds in the requirements.txt file but
with a note that these are not tested lower bounds and we
try our best to keep them updated.

[1] https://etherpad.opendev.org/p/tc-zed-ptg#L326
[2] https://governance.openstack.org/tc/resolutions/20220414-drop-lower-constraints.html#proposal

Change-Id: I73718d9f52d11b9a17ab49468743d5237179ada5
2022-04-30 20:20:37 -05:00
zhangboye
1005c4be5b Use TOX_CONSTRAINTS_FILE
UPPER_CONSTRAINTS_FILE is old name and deprecated
This allows to use upper-constraints file as more
readable way instead of UPPER_CONSTRAINTS_FILE=<lower-constraints file>.

Change-Id: Ie3771b123acace8320db5b2e8dfadeef1c2a1b90
2022-04-29 15:53:08 +00:00
Simon Li
1a138049f7 fix: miss attr _discovery_cache in ServiceTokenAuthWrapper
Add the super method to the ServiceTokenAuthWrapper class
to get the _discovery_cache attribute of the parent class.

the error info is below while neutron is authenticated by
keystoneauth plug in task inspector enroll baremetal node:
ERROR oslo_messaging.rpc.server:
Exception during message handling: AttributeError:
'ServiceTokenAuthWrapper' object has no attribute '_discovery_cache'

Change-Id: Icc7c4e25a123b5565c94f43f932ee32f9f304a76
2022-04-29 15:52:47 +00:00
shanyunfan33
af78d4a22c remove unicode from code
remove unicode from code

Change-Id: I95f201f5678f093981014a553ffadb2a6b2a0453
2022-04-29 15:48:17 +00:00
Zuul
2403661941 Merge "Update master for stable/yoga" 2022-03-22 15:26:47 +00:00
Zuul
030bc23893 Merge "Update master for stable/xena" 2022-03-22 15:25:39 +00:00
Zuul
d2b729d0c0 Merge "Update master for stable/wallaby" 2022-03-22 15:25:37 +00:00
08aa669b8f Update master for stable/yoga
Add file to the reno documentation build to show release notes for
stable/yoga.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/yoga.

Sem-Ver: feature
Change-Id: Ifd5fc37cb58a363e9bc9f2b2752d455555ba82e9
2022-03-11 10:48:21 -06:00
33776ab842 Update master for stable/xena
Add file to the reno documentation build to show release notes for
stable/xena.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/xena.

Sem-Ver: feature
Change-Id: I2621cf1da0b4721adfbb222bcf3f75e2f6a8d875
2022-03-11 10:47:28 -06:00
Zuul
27a3be4bc8 Merge "Clarify token_endpoint.Token usecases" 2022-03-04 17:27:46 +00:00
011d6b2f06 Update master for stable/wallaby
Add file to the reno documentation build to show release notes for
stable/wallaby.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/wallaby.

Sem-Ver: feature
Change-Id: I89924f9516f07caca3ae792aafc36587fd81badc
2022-03-04 16:50:54 +00:00
Zuul
8da0a63569 Merge "setup.cfg: Replace dashes by underscores" 2022-02-25 18:25:04 +00:00
Grzegorz Grasza
49db50bfb3 Fix bindep for current rpm based distributions
python-devel is no longer available in current RPM based distributions.
This was tested with centos7, rhel7, rhel8, fedora35.

Change-Id: I4a2e6886af6d6862f25957e7bb206a5fc9664d90
2022-02-21 16:13:26 +01:00
Takashi Kajinami
a1e209c9a1 setup.cfg: Replace dashes by underscores
Since setuptools v54.1.0[1], the parmeters with dash have been
deprecated in favor of the new parameters with underscore.

This change updates the parameters accordingly to avoid the warnings
like the example below.

  UserWarning: Usage of dash-separated 'description-file' will not be
  supported in future versions. Please use the underscore name
  'description_file' instead

[1] https://github.com/pypa/setuptools/commit/a2e9ae4cb

Change-Id: I3980fbc53ce4b954aff5e98087897ea94e50e4fc
2022-02-06 01:49:01 +09:00
Dr. Jens Harbott
7bbce9761c Fix docs build
Avoid conflicts between apidoc generated documentation and the source
code by adding "noindex" to SPHINX_APIDOC_OPTIONS.

Signed-off-by: Dr. Jens Harbott <harbott@osism.tech>
Change-Id: Ib1498a3712ec9cfd0abcb282b093f82ba0ee8128
2022-01-21 13:28:46 +01:00
Dmitry Tantsur
a3b4718233 User-friendly error message for DiscoveryFailure
The passage about discovery document and allow_version_hack makes little
sense for people unfamiliar with keystoneauth internals. What it
actually means in most cases is that the remote service is not
available. Rephrase the error message and add some debug logging.

Change-Id: I156dbb45bd8c07ace1900894f6779ed9f38cf3c6
2022-01-20 16:57:58 +01:00
Goutham Pacha Ravi
112bcae1fb Specify manila microversion header
Manila API honors a "X-OpenStack-Manila-API-Version"
header to specify microversions.

It may support the OpenStack-API-Version header
in a future release, however, we'll need to maintain
backwards compatibility with the existing API.

Change-Id: Ia2e62d3a11a08adeb6d488b7c9b365f7ff2be3c8
wallaby-em xena-em
2021-02-18 08:38:29 -08:00
Lance Bragstad
b8ddb3b75f Clarify token_endpoint.Token usecases
This authentication plugin isn't grouped with the other authentication
plugins, but it can be really useful for people writing proxies or
implementing service-to-service calls.

This commit just highlights the usefulness of this plugin with some
example usecases and a code snippet. The current documentation phrases
it such that it's only useful for testing.

Change-Id: I1de4959ccde3fdf8141d8f4949c73542c2200483
2021-01-08 21:57:16 +00:00
Zuul
6a662719ce Merge "Update master for stable/victoria" 2020-11-17 14:23:52 +00:00
maaoyu
10d9dfd8e1 bump py37 to py38 in tox.ini
in 'victoria' cycle, we should test py38 by default.

ref:
  https://governance.openstack.org/tc/reference/runtimes/victoria.html

Change-Id: I9cf801f2beda01b04e48488156fec0de11efe3a9
2020-10-12 13:34:19 +08:00
Dmitry Tantsur
d21c52867f Provide the default get_auth_ref implementation
osc-lib tries to call it, failing for e.g. http_basic.

Change-Id: Iacfba0940beda4dce2a9be0c863cb506d4013e2f
2020-09-17 12:28:35 +02:00
d441f33cd5 Update master for stable/victoria
Add file to the reno documentation build to show release notes for
stable/victoria.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/victoria.

Change-Id: Iee8f7c760fb33a5bc54724e50104eb638adff527
Sem-Ver: feature
2020-09-10 17:05:38 +00:00
Zuul
c2d2e7af29 Merge "Correct major version discovery for non-keystone plugins" victoria-em 2020-07-31 17:59:50 +00:00
Dmitry Tantsur
981a19bba1 Correct major version discovery for non-keystone plugins
When a non-keystone plugin is used together with an unversioned endpoint,
we give up on discovery before figuring out both major version and
the correct endpoint. This is because get_endpoint_data is called with
discover_versions=False, so discovery assumes we have all information
already. It may be an issue in discovery itself, but I'm afraid to
touch that code. Instead, if get_endpoint_data returns no API version
with discover_versions=False, try with discover_versions=True, which
matches what the identity plugins do.

Also increase the unit test coverage.

Change-Id: Ie623931b150748d7759cf276e0023a2f06a8d4db
2020-07-31 11:32:26 +02:00
Zuul
fda522ae10 Merge "Fix get_endpoint_data for non-keystone plugins" 2020-07-28 14:22:47 +00:00
Monty Taylor
a4ac1ea193 Fix docs builds for modern stevedors
We have a custom doc build extension that scans module names, but
the api for that changed.

Change-Id: If8c08d22dde3e570cdc6fb7092bc131e2e3bcc18
2020-07-27 11:13:15 -05:00
Monty Taylor
b95a89e3ff Fix get_endpoint_data for non-keystone plugins
We expect endpoint_override, but these plugins won't necessary
have it, they have endpoint instead.

Co-Authored-By: Dmitry Tantsur <dtantsur@protonmail.com>
Change-Id: Iead4b95c1f5b8d84cec705da32f41049e2eea641
2020-07-27 17:20:58 +02:00
Zuul
dab8e1057a Merge "Drop python 3.5 support" 2020-06-22 19:19:22 +00:00
Zuul
e0f1d314f4 Merge "Update lower-constraints versions" 2020-06-22 16:43:26 +00:00
Monty Taylor
4aaa2e52b0 Drop python 3.5 support
Now that we released ussuri, we have a stable release that supports
3.5. That means if needed we can backport changes needed for
zuul and nodepool, so it should be safe to go ahead and drop 3.5
support.

Change-Id: Iaaba139009f2b49815c29717d71b9182a6bec2ab
2020-06-22 10:04:17 -05:00
Steve Baker
ff68663217 Implement HTTP Basic client support in keystoneauth1
A new basic auth plugin is added which enables HTTP Basic
authentication for standalone services. Like the noauth plugin, the
endpoint needs to be specified explicitly, along with the
username and password.

An example of a standalone server implementing HTTP Basic can be seen
in Ironic change https://review.opendev.org/#/c/727467/

Change-Id: Ib3f0a9c518d031a67f9605cf64a8a9cc81131ed3
Story: 2007656
Task: 39741
2020-06-15 10:26:35 +12:00
Sean McGinnis
8915fabc38
Update lower-constraints versions
This updates lower constraints to versions that will work with py38 so
that when we move to running on focal nodes, which has py38 as its
default py3 runtime, the lower-constraints job will continue to pass.

It also cleans out some secondary requirements that are no longer needed
due to our direct dependencies being updated.

Linters are removed that are kept in the global requirements blacklist
as those are not version tracked and are not relevant for our
lower-constraints unit test runs.

Change-Id: I228212d8347a33a6bc2735a8506acffe58bee2ec
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
2020-06-10 06:42:37 -05:00
Sean McGinnis
646192d7fd
Remove mox3 from local upper-constraints
The py35-upper-constraints.txt file listed mox3, but mox3 is not
actually used by the project. This cleans up the list to make sure it
only lists packages that are actually needed.

Change-Id: I8f28e69cdcdd96e927c9cf5b9ed718448513118f
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
2020-06-08 07:48:52 -05:00
Zuul
94314329e9 Merge "Replace assertItemsEqual with assertCountEqual" 2020-06-05 04:45:24 +00:00
Zuul
e96c2102ad Merge "Use unittest.mock instead of third party mock" 2020-06-05 04:21:48 +00:00
Zuul
5445f779ed Merge "Add in-tree upper-constraints for py35 job" 2020-06-03 18:13:00 +00:00
Zuul
1f0412a042 Merge "Make header Case Insensitive" 2020-06-03 17:57:33 +00:00
Joel Capitao
1fe8df2bc8 Replace assertItemsEqual with assertCountEqual
assertItemsEqual was removed from Python's unittest.TestCase in
Python 3.3 [1][2]. We have been able to use them since then, because
testtools required unittest2, which still included it. With testtools
removing Python 2.7 support [3][4], we will lose support for
assertItemsEqual, so we should switch to use assertCountEqual.
Credits to [5].

[1] - https://bugs.python.org/issue17866
[2] - https://hg.python.org/cpython/rev/d9921cb6e3cd
[3] - testing-cabal/testtools#286
[4] - testing-cabal/testtools#277
[5] - https://review.opendev.org/#/c/732393/

Change-Id: Ib1db7694a8f0f59d8762b02acbb4ef16e5176098
2020-06-03 15:14:41 +02:00
Ghanshyam Mann
c1e843b0cd Add in-tree upper-constraints for py35 job
It is difficult to keep the py35 upper constraints on reqiorements
repo's upper-constarint.txt file as update-constraint tools generate
the new file everytime with official supported python version only
which is py3.6 and py3.8 for Victoria cycle
- https://review.opendev.org/#/c/730428

Let's keep the py3.5 constraints in-tree which can be used in py35
unit test job.

Change-Id: Iec2eaa2b7e8df777b6988c2134e7771b9b1fb5b5
2020-06-01 15:45:07 +00:00
Ghanshyam Mann
c00fca4a09 Make header Case Insensitive
In case of global-request-id request, Adapter
send two global request id header
 - "X-OpenStack-Request-ID"
 - "X-Openstack-Request-Id".

Example: https://zuul.opendev.org/t/openstack/build/c5b1debf78df4aa3bdda34f0b4c53c37/log/testrepository.subunit#2385

This is becasue of the header not being Case Insensitive
and end up with two different name of same header with difference
of cap 'D'.

Unit test for whether request global-request-id has precedence
over adapter fail many times because of how different python version
treat the dict. py3.6 and above are all good as dict maintain the
insertion ordered but py3.5 can fail it any time.

We can see consistent failure in py35 jobs:
- https://review.opendev.org/#/c/730687/

Let's make the headers always Case Insensitive which is
what RFC says.

Change-Id: Iba707dd0506d22e144aca4fdfc9b140c8e37ae02
Closes-Bug: #1881351
2020-05-29 17:17:11 -05:00
Zuul
7d03b2b2f4 Merge "Switch to newer openstackdocstheme and reno versions" 2020-05-29 18:59:56 +00:00
Sean McGinnis
edc2ae4249
Use unittest.mock instead of third party mock
Now that we no longer support py27, we can use the standard library
unittest.mock module instead of the third party mock lib.

Change-Id: I07d61e1a8f18d65acdf86cdd61f7d9e28157f1d7
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
2020-05-29 10:37:58 -05:00
zhangboye
38374adab6 Add py38 package metadata
Change-Id: I6ec1530d9ddc844f3ba687fe94f5fcdd3670122f
2020-05-22 09:38:27 -05:00
Lance Bragstad
ad46262148 Inject /v3 in token path for v3 plugins
Without this, it's possible to get HTTP 404 errors from keystone if
OS_AUTH_URL isn't versioned (e.g., https://keystone.example.com/ instead
of https://keystone.example.com/v3), even if OS_IDENTITY_API is set to
3.

This commit works around this issue by checking the AUTH_URL before
building the token_url and appending '/v3' to the URL before sending the
request.

Closes-Bug: 1876317

Change-Id: Ic75f0c9b36022b884105b87bfe05f4f8292d53b2
2020-05-22 09:38:27 -05:00
Ghanshyam Mann
fdd4078202 Fix hacking min version to 3.0.1
flake8 new release 3.8.0 added new checks and gate pep8
job start failing. hacking 3.0.1 fix the pinning of flake8 to
avoid bringing in a new version with new checks.

Though it is fixed in latest hacking but 2.0 and 3.0 has cap for
flake8 as <4.0.0 which mean flake8 new version 3.9.0 can also
break the pep8 job if new check are added.

Cap pycodestyle also  as flake8-import-order does not cap the pycodestyle
and pull its latest version and break things.

Also removing the pycodestyle from lower-constraints file
as theose are blacklisted requirements and does not need to be present
there.

To avoid similar gate break in future, we need to bump the hacking min
version.

- http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014828.html

Change-Id: I003f8f63e06c5263ef88df9dab90bbd74cb62ea5
2020-05-22 09:38:27 -05:00